stevedlawrence commented on code in PR #1634:
URL: https://github.com/apache/daffodil/pull/1634#discussion_r2854894053
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/util/FuzzData.scala:
##########
@@ -175,8 +175,8 @@ class FuzzParseTester(
try {
TestUtils.runDataProcessorOnInputStream(p, bais, areTracing = false)
} catch {
- case p: ParseError => {
- handleParseError(p, testData, i)
+ case p: MultiException[Throwable] @unchecked => {
Review Comment:
Does this need to be marked as unchecked?
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/util/FuzzData.scala:
##########
@@ -207,7 +211,11 @@ class LayerParseTester(
var shouldFail = false
- override def handleParseError(p: ParseError, data: Array[Byte], nth: Int):
Unit = {
Review Comment:
Is it worth changing the argument names from `p` to `ex` or something to
better match what the argument represents?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
