stricklandrbls commented on code in PR #1668: URL: https://github.com/apache/daffodil-vscode/pull/1668#discussion_r3175833846
########## src/dataEditor/dataEditorClient.ts: ########## Review Comment: Setting a boundary on `length` resolves the profile request API crash issue I saw: ```ts const DATA_PROFILE_MAX_LENGTH = 10_000_000 const startOffset: number = message.data.startOffset let length: number = message.data.length length = length <= 0 ? DATA_PROFILE_MAX_LENGTH : length ``` ########## src/dataEditor/dataEditorClient.ts: ########## Review Comment: I'm not sure why it will not let me resolve this issue. I may end up just having to delete it because it will not let me approve the PR with pending comments. ########## src/dataEditor/dataEditorClient.ts: ########## Review Comment: so I was about to push up this change to get it through but I was testing with a file that had a size of 67 bytes but still saw the profile crashing issue. both the start offset and length were valid offsets. I'll have to dig a little deeper. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
