olabusayoT commented on code in PR #1650:
URL: https://github.com/apache/daffodil/pull/1650#discussion_r3274952832
##########
daffodil-core/src/main/scala/org/apache/daffodil/lib/xml/XMLUtils.scala:
##########
@@ -1055,6 +1155,28 @@ Differences were (path, expected, actual):
computeTextDiff(zPath, tA, tB, maybeType, maybeFloatEpsilon,
maybeDoubleEpsilon)
thisDiff
}
+ case (cA: Comment, cB: Comment) => {
+ val thisDiff = computeTextDiff(
+ zPath,
+ cA.toString,
+ cB.toString,
+ maybeType,
+ maybeFloatEpsilon,
+ maybeDoubleEpsilon
Review Comment:
So I tested this and inline comment ends up having its own type who is None.
foo is a separate iteration of computeDiff and is what actually carries the
type. But for extra precaution, will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
