stevedlawrence commented on code in PR #1674:
URL: https://github.com/apache/daffodil/pull/1674#discussion_r3324157381
##########
daffodil-core/src/main/java/org/apache/daffodil/layers/runtime1/GZipLayer.java:
##########
@@ -63,7 +91,7 @@ public InputStream wrapLayerInput(InputStream jis) throws
Exception {
@Override
public OutputStream wrapLayerOutput(OutputStream jos) throws Exception {
OutputStream fixedOS = fixIsNeeded() ? new GZIPFixedOutputStream(jos) :
jos;
Review Comment:
I just remembered that the GZIPFixedOutputStream is only needed JVMs older
than Java 16. But Daffodil's minimum supported version is now 17, so this can
never be used. Can you delete everything related to GZIPFixedOutputStream and
the fixIsNeeded variable. This layer is often used as an example, so keeping it
as simple as possible and removing dead code is beneficial. Can be done as part
of this PR or a separate one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
