Copilot commented on code in PR #1705:
URL: https://github.com/apache/daffodil-vscode/pull/1705#discussion_r3324939968
##########
package.json:
##########
@@ -221,12 +221,12 @@
},
{
"command": "infoset.display",
- "when": "inDebugMode && editorLangId == 'dfdl'",
+ "when": "inDebugMode",
"group": "navigation@2"
},
{
"command": "infoset.diff",
- "when": "inDebugMode && editorLangId == 'dfdl'",
+ "when": "inDebugMode",
"group": "navigation@3"
Review Comment:
The editor/title menu items are now shown whenever `inDebugMode` is true,
but the contributed commands `infoset.display` and `infoset.diff` are still
gated by `enablement: "inDebugMode && editorLangId == 'dfdl'"` in the
`commands` section. In practice this will cause the new buttons to appear but
remain disabled when the focused editor isn’t a DFDL text editor (e.g., the
Daffodil Helper webview), which doesn’t match the PR goal of making them usable
regardless of focused editor language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
