[ 
https://issues.apache.org/jira/browse/DAFFODIL-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Lawrence resolved DAFFODIL-3081.
--------------------------------------
    Fix Version/s: 4.2.0
       Resolution: Fixed

Fixed in commit ec72d23c408347a1ac97b0e27e5d2c8b348d766a

> Configure codecov to not fail on master branch merges
> -----------------------------------------------------
>
>                 Key: DAFFODIL-3081
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-3081
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Infrastructure
>            Reporter: Steve Lawrence
>            Priority: Minor
>             Fix For: 4.2.0
>
>
> Codecov is used in pull requests to check if a PR has sufficient code 
> coverage. If a PR does not meet some threshold, the PR gets a red X to make 
> this clear. Note that this red X is not necessarily a blocker since it is 
> sometimes not possible or reasonable to meet the codecov requirement for some 
> PRs, and so we might merge a PR anyways.
> But when we do this, codecov also runs on the main branch to give us our 
> overall coverage, but it will show the same red X making it look like CI 
> failed on the main branch. By merging a PR we are tacitly accepting whatever 
> code coverage it results in, so there is no reason to make the main branch CI 
> look like it failed, which could make it less likely to notice actual main 
> branch failures.
> We should configure codecov so that the main branch runs never cause a 
> failure due to low patch code coverage.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to