olabusayoT commented on code in PR #1677:
URL: https://github.com/apache/daffodil/pull/1677#discussion_r3365524683
##########
daffodil-test/src/test/scala/org/apache/daffodil/section23/dfdl_expressions/TestDFDLExpressions.scala:
##########
@@ -766,7 +766,7 @@ class TestDFDLFunctions extends TdmlTests {
@Test def yearfromdatetime_01 = test
@Test def yearfromdatetime_02 = test
- @Test def yearfromdatetime_03 = test
+ @Ignore @Test def yearfromdatetime_03 = test
Review Comment:
Can you add a comment to this ignore explaining why we are ignoring these
tests
##########
daffodil-test/src/test/scala/org/apache/daffodil/section23/dfdl_expressions/TestDFDLExpressions.scala:
##########
@@ -766,7 +766,7 @@ class TestDFDLFunctions extends TdmlTests {
@Test def yearfromdatetime_01 = test
@Test def yearfromdatetime_02 = test
- @Test def yearfromdatetime_03 = test
+ @Ignore("year zero is invalid per XSD 1.0") @Test def yearfromdatetime_03 =
test
Review Comment:
I was actually confused as to why we were ignoreng the tests with no
context, can we add the Daffodil bug comment above so poeple know?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
