stevedlawrence commented on code in PR #1682:
URL: https://github.com/apache/daffodil/pull/1682#discussion_r3398156173
##########
daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_functions/Functions.tdml:
##########
@@ -14735,7 +14735,94 @@
</tdml:dfdlInfoset>
</tdml:infoset>
</tdml:parserTestCase>
-
+
+
+ <tdml:defineSchema name="MicrosecondsDateTime.dfdl.xsd">
Review Comment:
Agreed with Lola. It looks like the convention is mostly to not use
.dfdl.xsd for embedded schemas. We have 600+ defineSchemas that do not use it
and 80+ that do.
So I would suggest drop the .dfdl.xsd for new tests, but keep the old ones
as is. I'm not sure it's worth teh code churn to updating our existing tests
for something that is only a loose convention. If we have a good argument for
it, we can do it in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
