Copilot commented on code in PR #1718:
URL: https://github.com/apache/daffodil-vscode/pull/1718#discussion_r3405688504
##########
.github/workflows/documentaion.yml:
##########
@@ -30,20 +25,19 @@ on:
jobs:
enforce-checkbox:
- # this if is to further ensure that this job won't run on dependabot or
scala-steward PRs
if: ${{ !startsWith(github.head_ref, 'dependabot/') &&
!startsWith(github.head_ref, 'update/') }}
runs-on: ubuntu-22.04
steps:
- name: Check required confirmation checkbox
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 #
v7
with:
script: |
- const prBody = context.payload.pull_request.body || "";
+ const prBody = context.payload.pull_request?.body || "";
const checkbox1Text = "- [x] I have determined that no
documentation updates are needed for these changes";
const checkbox2Text = "- [x] I have added the following
documentation for these changes";
-
+
if (!prBody.includes(checkbox1Text) &&
!prBody.includes(checkbox2Text)) {
- core.setFailed("❌ Required documentation checkbox not checked.
Please check one of the the box before merging.");
+ core.setFailed("❌ Required documentation checkbox not checked.
Please check one of the the boxes before merging.");
Review Comment:
The failure message contains a duplicated word ("the the"), which reads
unpolished in a user-facing error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
