stevedlawrence commented on issue #610: URL: https://github.com/apache/daffodil-vscode/issues/610#issuecomment-4832153730
Note that I don't think this bug is about big/little endian byte order. It is about *bitOrder*, which has values of most signficiant bit first or least significant bit first (which the MSB or LSB referenced in the ticket). We have documentation that describes bit order and it's implications here: https://daffodil.apache.org/tutorials/bitorder.tutorial.tdml.xml And in the DFDL specification here: https://daffodil.apache.org/docs/dfdl/#_Toc62570139 Note that I'm not sure the "2048" hex editor example in the tutorial is correct, or at least it doesn't follow my mental model of bit order. So we should have some design discussions about exactly what this would look like in a hex editor if you do decide to implement this and verify the correctness of that example. Also note that bitOrder really only makes a difference when you have lengths that are not a multiple of 8 bits. It looks like the data editor only supports multiple of 8 bit integers, so in order to support a concept of bit order it would probably need to support arbitrary bit lengths first. I'll leave it up to you if you want to support non-8 bit lengths and bit order or not (they would be useful features for formats link vmf, link16, and densely packed binary). But I don't think this bug should be marked as completed. I would recommend closing as something like won't fix if there are no plans of adding this support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
