stricklandrbls commented on PR #1716: URL: https://github.com/apache/daffodil-vscode/pull/1716#issuecomment-5171508298
The latest commit should resolve the following lingering issues discovered by @lrbarber & @hdalsania ## Phantom `0xFF` Byte Frequency in Large Files There was an issue for the data editor's profiler where when profiling large files a phantom `0xFF` byte would be listed in the frequency graph if the profiled data section's length / end offset changed. <details><summary><b>Test Procedure</b></summary> 1. Open a standalone data editor instance via the command prompt (Ctrl-Shift-P). 2. Select a target file with a file size greater than 150KB. 3. Press the profiler data button. 4. Update the end offset to a relatively small selection where no `0xFF` value exists. 5. Verify that the frequency graph **does not** display a `0xFF` value. </details> ## Profiler Offset Indices Offset by 1 The profiled data selection offsets did not include the correct amount of bytes relative to their index positions. For example, if the start offset was 0 and the end offset was 1 then only 1 byte would be displayed. <details><summary><b>Test Procedure</b></summary> 1. Open a standalone data editor instance via the command prompt (Ctrl-Shift-P). 2. Open a target file with a file size greater than 3 bytes. 3. Press the profiler data button. 4. Update the end offset to 1. 5. Verify that the first two bytes are included in the frequency graph. </details> ## Profiler Initial File Size The profiler would list the end offset as the value of the data editor max byte profile count (10,000,000). <details><summary><b>Test Procedure</b></summary> 1. Open a standalone data editor instance via the command prompt (Ctrl-Shift-P). 2. Open a target file. 3. Press the profiler data button. 4. Verify that the end offset and length values match the appropriate file size. </details> ## Profiler Frequency Byte Hover Value Radix The profiler would only display the byte values in decimal radix <details><summary><b>Test Procedure</b></summary> 1. Open a standalone data editor instance via the command prompt (Ctrl-Shift-P). 2. Open a target file. 3. Press the profiler data button. 4. Hover an arbitrary value in the frequency graph and verify the display value radix matches the current selected display radix. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
