olabusayoT commented on code in PR #48:
URL:
https://github.com/apache/daffodil-infrastructure/pull/48#discussion_r3760374697
##########
actions/release-candidate/dist/post/index.js:
##########
@@ -125633,6 +125642,9 @@ async function run() {
if (artifact.name.endsWith(".rpm")) {
await exec("rpmsign", ["--define",
`_gpg_name ${ gpg_signing_key_id }`, "--define", "_binary_filedigest_algorithm
10", "--addsign", `${ artifact.parentPath }/${ artifact.name }`]);
}
+ if (artifact.name.endsWith(".exe") &&
do_ssl_com_sign) {
+ await exec("jsign", ["--storetype",
"ESIGNER", "--alias", "d97c5110-c66a-4c0c-ac0c-1cd6af812ee6", "--storepass",
`${ssl_com_username}|${ssl_com_password}`, "--keypass", ssl_com_secret,
"--tsaurl=http://ts.ssl.com";, "--tsmode", "RFC3161", "--alg", "SHA256", `${
artifact.parentPath }/${ artifact.name }`]);
Review Comment:
can we move the alias into a descriptive variable or with a comment
discussing its origin?
##########
actions/release-candidate/dist/post/index.js:
##########
@@ -125633,6 +125642,9 @@ async function run() {
if (artifact.name.endsWith(".rpm")) {
await exec("rpmsign", ["--define",
`_gpg_name ${ gpg_signing_key_id }`, "--define", "_binary_filedigest_algorithm
10", "--addsign", `${ artifact.parentPath }/${ artifact.name }`]);
}
+ if (artifact.name.endsWith(".exe") &&
do_ssl_com_sign) {
+ await exec("jsign", ["--storetype",
"ESIGNER", "--alias", "d97c5110-c66a-4c0c-ac0c-1cd6af812ee6", "--storepass",
`${ssl_com_username}|${ssl_com_password}`, "--keypass", ssl_com_secret,
"--tsaurl=http://ts.ssl.com";, "--tsmode", "RFC3161", "--alg", "SHA256", `${
artifact.parentPath }/${ artifact.name }`]);
Review Comment:
Also the alg is 256 here, but below we mention sha512; just verifying the
discrepancy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
