alamb commented on code in PR #10088:
URL: https://github.com/apache/datafusion/pull/10088#discussion_r1575265148
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -895,6 +891,31 @@ fn convert_to_sort_cols(
.collect::<Vec<_>>()
}
+fn replace_order_by_clause(order_by: &mut String) {
Review Comment:
Rather than doing string manipulation here, maybe we could call
`create_function_physical_name` to just create the right name in the first
place 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@datafusion.apache.org
For additional commands, e-mail: commits-h...@datafusion.apache.org
