alamb commented on code in PR #10098:
URL: https://github.com/apache/datafusion/pull/10098#discussion_r1575310332
##########
datafusion/expr/src/expr.rs:
##########
@@ -362,10 +362,6 @@ impl Between {
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
/// Defines which implementation of a function for DataFusion to call.
pub enum ScalarFunctionDefinition {
- /// Resolved to a `BuiltinScalarFunction`
- /// There is plan to migrate `BuiltinScalarFunction` to UDF-based
implementation (issue#8045)
- /// This variant is planned to be removed in long term
- BuiltIn(BuiltinScalarFunction),
/// Resolved to a user defined function
UDF(Arc<crate::ScalarUDF>),
/// A scalar function constructed with name. This variant can not be
executed directly
Review Comment:
Tracked in https://github.com/apache/datafusion/issues/10175
##########
datafusion/functions/src/math/coalesce.rs:
##########
@@ -0,0 +1,141 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Tracked in https://github.com/apache/datafusion/issues/10174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
