matthewmturner commented on code in PR #10125:
URL: https://github.com/apache/datafusion/pull/10125#discussion_r1575440108
##########
datafusion/execution/src/cache/cache_unit.rs:
##########
@@ -232,4 +337,64 @@ mod tests {
meta.clone()
);
}
+ #[test]
Review Comment:
Ref to [postgres](https://www.postgresql.org/docs/current/sql-explain.html)
Specifically:
```
Include information on buffer usage. Specifically, include the number of
shared blocks hit, read, dirtied, and written, the number of local blocks hit,
read, dirtied, and written, the number of temp blocks read and written, and the
time spent reading and writing data file blocks and temporary file blocks (in
milliseconds) if
[track_io_timing](https://www.postgresql.org/docs/current/runtime-config-statistics.html#GUC-TRACK-IO-TIMING)
is enabled. A hit means that a read was avoided because the block was found
already in cache when needed.```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@datafusion.apache.org
For additional commands, e-mail: commits-h...@datafusion.apache.org
