edmondop commented on code in PR #10186:
URL: https://github.com/apache/datafusion/pull/10186#discussion_r1575501494
##########
datafusion/common/src/error.rs:
##########
@@ -778,6 +817,20 @@ mod test {
);
}
+ #[test]
+ fn test_strip_error_name() {
+ let res: Result<(), DataFusionError> = plan_err!("Err");
+ let res = res.unwrap_err();
+ assert_eq!(res.strip_error_name(), "Err");
+
+ // Test only top level stripped
+ let res: Result<(), DataFusionError> = plan_err!("Err");
Review Comment:
It looks like these are two scenarios that you are testing, should they go
in two different test cases ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
