etolbakov commented on code in PR #1011:
URL:
https://github.com/apache/datafusion-ballista/pull/1011#discussion_r1582855321
##########
ballista/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -297,13 +298,24 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerGrpc
// TODO shouldn't this take a ListingOption object as input?
let GetFileMetadataParams { path, file_type } = request.into_inner();
- let file_format: Arc<dyn FileFormat> = match file_type.as_str() {
+ let file_format: Result<Arc<dyn FileFormat>, Status> = match
file_type.as_str() {
"parquet" => Ok(Arc::new(ParquetFormat::default())),
Review Comment:
I've noticed that in the
[benchmark](https://github.com/apache/datafusion-ballista/blob/04766d5fd7cbb15d583f736979c11de06c720928/benchmarks/src/bin/tpch.rs#L830)
there's slightly different `default` for parquet:
```rust
ParquetFormat::default().with_enable_pruning(Some(true))
```
I wonder if we need consistency or it's ok to leave it as is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
