This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new eddec8e788 Implement unparse `IS_NULL` to String and enhance the tests
(#10529)
eddec8e788 is described below
commit eddec8e78865c0f17bd089af641492b1d8e8a411
Author: Jax Liu <[email protected]>
AuthorDate: Thu May 16 07:43:17 2024 +0800
Implement unparse `IS_NULL` to String and enhance the tests (#10529)
* implement unparse is_null and add test
* format the code
---
datafusion/sql/src/unparser/expr.rs | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/datafusion/sql/src/unparser/expr.rs
b/datafusion/sql/src/unparser/expr.rs
index 804fa6d306..23e3d9ab35 100644
--- a/datafusion/sql/src/unparser/expr.rs
+++ b/datafusion/sql/src/unparser/expr.rs
@@ -391,7 +391,9 @@ impl Unparser<'_> {
Expr::ScalarVariable(_, _) => {
not_impl_err!("Unsupported Expr conversion: {expr:?}")
}
- Expr::IsNull(_) => not_impl_err!("Unsupported Expr conversion:
{expr:?}"),
+ Expr::IsNull(expr) => {
+ Ok(ast::Expr::IsNull(Box::new(self.expr_to_sql(expr)?)))
+ }
Expr::IsNotFalse(_) => not_impl_err!("Unsupported Expr conversion:
{expr:?}"),
Expr::GetIndexedField(_) => {
not_impl_err!("Unsupported Expr conversion: {expr:?}")
@@ -863,7 +865,7 @@ mod tests {
use datafusion_expr::{
case, col, exists,
expr::{AggregateFunction, AggregateFunctionDefinition},
- lit, not, not_exists, table_scan, wildcard, ColumnarValue, ScalarUDF,
+ lit, not, not_exists, table_scan, when, wildcard, ColumnarValue,
ScalarUDF,
ScalarUDFImpl, Signature, Volatility, WindowFrame,
WindowFunctionDefinition,
};
@@ -933,6 +935,14 @@ mod tests {
.otherwise(lit(ScalarValue::Null))?,
r#"CASE "a" WHEN 1 THEN true WHEN 0 THEN false ELSE NULL END"#,
),
+ (
+ when(col("a").is_null(), lit(true)).otherwise(lit(false))?,
+ r#"CASE WHEN "a" IS NULL THEN true ELSE false END"#,
+ ),
+ (
+ when(col("a").is_not_null(), lit(true)).otherwise(lit(false))?,
+ r#"CASE WHEN "a" IS NOT NULL THEN true ELSE false END"#,
+ ),
(
Expr::Cast(Cast {
expr: Box::new(col("a")),
@@ -959,6 +969,18 @@ mod tests {
ScalarUDF::new_from_impl(DummyUDF::new()).call(vec![col("a"),
col("b")]),
r#"dummy_udf("a", "b")"#,
),
+ (
+ ScalarUDF::new_from_impl(DummyUDF::new())
+ .call(vec![col("a"), col("b")])
+ .is_null(),
+ r#"dummy_udf("a", "b") IS NULL"#,
+ ),
+ (
+ ScalarUDF::new_from_impl(DummyUDF::new())
+ .call(vec![col("a"), col("b")])
+ .is_not_null(),
+ r#"dummy_udf("a", "b") IS NOT NULL"#,
+ ),
(
Expr::Like(Like {
negated: true,
@@ -1081,6 +1103,7 @@ mod tests {
r#"COUNT(*) OVER (ORDER BY "a" DESC NULLS FIRST RANGE BETWEEN
6 PRECEDING AND 2 FOLLOWING)"#,
),
(col("a").is_not_null(), r#""a" IS NOT NULL"#),
+ (col("a").is_null(), r#""a" IS NULL"#),
(
(col("a") + col("b")).gt(lit(4)).is_true(),
r#"(("a" + "b") > 4) IS TRUE"#,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
