This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 682fc05452 Fix running examples readme (#11225)
682fc05452 is described below
commit 682fc054524e1aec4874bf6e76970b680e79d5aa
Author: Piotr Findeisen <[email protected]>
AuthorDate: Sat Jul 6 13:26:11 2024 +0200
Fix running examples readme (#11225)
* Fix running examples readme
Some examples are runnable from any place (e.g. `csv_sql`), but some
expect a specific working directory (e.g. `regexp`). Running from
`datafusion-examples/examples` is tested on CI so guaranteed to work,
let's put this path in the README.
As a follow-up, we should look what it would take to make examples
runnable directly from an IDE such as RustRover.
* Remove doubled fmt check from CI
Examples' format is checked in `check-fmt` job, so can be skipped in
`rust_example.sh`.
---
ci/scripts/rust_example.sh | 1 -
datafusion-examples/README.md | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/ci/scripts/rust_example.sh b/ci/scripts/rust_example.sh
index 0415090665..1bb97c8810 100755
--- a/ci/scripts/rust_example.sh
+++ b/ci/scripts/rust_example.sh
@@ -19,7 +19,6 @@
set -ex
cd datafusion-examples/examples/
-cargo fmt --all -- --check
cargo check --examples
files=$(ls .)
diff --git a/datafusion-examples/README.md b/datafusion-examples/README.md
index f868a5310c..90469e6715 100644
--- a/datafusion-examples/README.md
+++ b/datafusion-examples/README.md
@@ -36,6 +36,9 @@ cd datafusion
# Download test data
git submodule update --init
+# Change to the examples directory
+cd datafusion-examples/examples
+
# Run the `dataframe` example:
# ... use the equivalent for other examples
cargo run --example dataframe
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
