This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 336c15e759 Improve MSRV CI check to print out problems to log (#11789)
336c15e759 is described below
commit 336c15e759c334debb7834088af698ec6b03763a
Author: Andrew Lamb <[email protected]>
AuthorDate: Mon Aug 5 06:51:10 2024 -0400
Improve MSRV CI check to print out problems to log (#11789)
* Improve MSRV CI check to print out problems to log
* Add reproduction instructions
* Use `verify` and add `output-format` option
* Update .github/workflows/rust.yml
Co-authored-by: Eduard Karacharov <[email protected]>
---------
Co-authored-by: Eduard Karacharov <[email protected]>
---
.github/workflows/rust.yml | 32 +++++++++++++++++++++++---------
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index fd8c2d2090..00d31765e7 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -566,18 +566,32 @@ jobs:
- name: Check datafusion
working-directory: datafusion/core
run: |
- # If you encounter an error with any of the commands below
- # it means some crate in your dependency tree has a higher
- # MSRV (Min Supported Rust Version) than the one specified
- # in the `rust-version` key of `Cargo.toml`. Check your
- # dependencies or update the version in `Cargo.toml`
- cargo msrv verify
+ # If you encounter an error with any of the commands below it means
+ # your code or some crate in the dependency tree has a higher MSRV
+ # (Min Supported Rust Version) than the one specified in the
+ # `rust-version` key of `Cargo.toml`.
+ #
+ # To reproduce:
+ # 1. Install the version of Rust that is failing. Example:
+ # rustup install 1.76.0
+ # 2. Run the command that failed with that version. Example:
+ # cargo +1.76.0 check -p datafusion
+ #
+ # To resolve, either:
+ # 1. Change your code to use older Rust features,
+ # 2. Revert dependency update
+ # 3. Update the MSRV version in `Cargo.toml`
+ #
+ # Please see the DataFusion Rust Version Compatibility Policy before
+ # updating Cargo.toml. You may have to update the code instead.
+ #
https://github.com/apache/datafusion/blob/main/README.md#rust-version-compatibility-policy
+ cargo msrv --output-format json --log-target stdout verify
- name: Check datafusion-substrait
working-directory: datafusion/substrait
- run: cargo msrv verify
+ run: cargo msrv --output-format json --log-target stdout verify
- name: Check datafusion-proto
working-directory: datafusion/proto
- run: cargo msrv verify
+ run: cargo msrv --output-format json --log-target stdout verify
- name: Check datafusion-cli
working-directory: datafusion-cli
- run: cargo msrv verify
\ No newline at end of file
+ run: cargo msrv --output-format json --log-target stdout verify
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
