This is an automated email from the ASF dual-hosted git repository.
comphead pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new 165fd43a remove assume() as the tests works for spark 3.3 (#923)
165fd43a is described below
commit 165fd43a6ef58db443a724b08130c796460c2acc
Author: Himadri Pal <[email protected]>
AuthorDate: Wed Sep 11 08:36:42 2024 -0700
remove assume() as the tests works for spark 3.3 (#923)
Co-authored-by: himadripal <[email protected]>
---
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala | 6 ------
1 file changed, 6 deletions(-)
diff --git a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
index 3701be5f..c02875a6 100644
--- a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
@@ -298,9 +298,6 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
test("cast timestamp and timestamp_ntz to string") {
- // TODO: make the test pass for Spark 3.3
- assume(isSpark34Plus)
-
withSQLConf(
SESSION_LOCAL_TIMEZONE.key -> "Asia/Kathmandu",
CometConf.COMET_CAST_ALLOW_INCOMPATIBLE.key -> "true") {
@@ -323,9 +320,6 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
test("cast timestamp and timestamp_ntz to long, date") {
- // TODO: make the test pass for Spark 3.3
- assume(isSpark34Plus)
-
withSQLConf(
SESSION_LOCAL_TIMEZONE.key -> "Asia/Kathmandu",
CometConf.COMET_CAST_ALLOW_INCOMPATIBLE.key -> "true") {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
