This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new fa95b7584a Clarify documentation on ArrowBytesMap and
ArrowBytesViewMap (#12789)
fa95b7584a is described below
commit fa95b7584a058dda2f614553ecaba1f856fcf686
Author: Andrew Lamb <[email protected]>
AuthorDate: Wed Oct 9 06:36:43 2024 -0400
Clarify documentation on ArrowBytesMap and ArrowBytesViewMap (#12789)
---
datafusion/physical-expr-common/src/binary_map.rs | 5 +++--
datafusion/physical-expr-common/src/binary_view_map.rs | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/datafusion/physical-expr-common/src/binary_map.rs
b/datafusion/physical-expr-common/src/binary_map.rs
index f320ebcc06..03ac4769d9 100644
--- a/datafusion/physical-expr-common/src/binary_map.rs
+++ b/datafusion/physical-expr-common/src/binary_map.rs
@@ -104,8 +104,9 @@ impl<O: OffsetSizeTrait> ArrowBytesSet<O> {
/// `Binary`, and `LargeBinary`) values that can produce the set of keys on
/// output as `GenericBinaryArray` without copies.
///
-/// Equivalent to `HashSet<String, V>` but with better performance for arrow
-/// data.
+/// Equivalent to `HashSet<String, V>` but with better performance if you need
+/// to emit the keys as an Arrow `StringArray` / `BinaryArray`. For other
+/// purposes it is the same as a `HashMap<String, V>`
///
/// # Generic Arguments
///
diff --git a/datafusion/physical-expr-common/src/binary_view_map.rs
b/datafusion/physical-expr-common/src/binary_view_map.rs
index bdcf7bbacc..c6768a19d3 100644
--- a/datafusion/physical-expr-common/src/binary_view_map.rs
+++ b/datafusion/physical-expr-common/src/binary_view_map.rs
@@ -88,8 +88,9 @@ impl ArrowBytesViewSet {
/// values that can produce the set of keys on
/// output as `GenericBinaryViewArray` without copies.
///
-/// Equivalent to `HashSet<String, V>` but with better performance for arrow
-/// data.
+/// Equivalent to `HashSet<String, V>` but with better performance if you need
+/// to emit the keys as an Arrow `StringViewArray` / `BinaryViewArray`. For
other
+/// purposes it is the same as a `HashMap<String, V>`
///
/// # Generic Arguments
///
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
