This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new db85d07e6a chores: remove redundant clone (#12964)
db85d07e6a is described below
commit db85d07e6ae68570c47e956aa020da027fb7bebc
Author: JasonLi <[email protected]>
AuthorDate: Wed Oct 16 22:55:58 2024 +0800
chores: remove redundant clone (#12964)
---
datafusion-cli/src/exec.rs | 2 +-
datafusion-cli/src/object_storage.rs | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/datafusion-cli/src/exec.rs b/datafusion-cli/src/exec.rs
index db4242d971..1890653669 100644
--- a/datafusion-cli/src/exec.rs
+++ b/datafusion-cli/src/exec.rs
@@ -383,7 +383,7 @@ pub(crate) async fn
register_object_store_and_config_extensions(
ctx.register_table_options_extension_from_scheme(scheme);
// Clone and modify the default table options based on the provided options
- let mut table_options =
ctx.session_state().default_table_options().clone();
+ let mut table_options = ctx.session_state().default_table_options();
if let Some(format) = format {
table_options.set_config_format(format);
}
diff --git a/datafusion-cli/src/object_storage.rs
b/datafusion-cli/src/object_storage.rs
index e8d60e4f09..3d999766e0 100644
--- a/datafusion-cli/src/object_storage.rs
+++ b/datafusion-cli/src/object_storage.rs
@@ -495,7 +495,7 @@ mod tests {
if let LogicalPlan::Ddl(DdlStatement::CreateExternalTable(cmd)) = &mut
plan {
ctx.register_table_options_extension_from_scheme(scheme);
- let mut table_options =
ctx.state().default_table_options().clone();
+ let mut table_options = ctx.state().default_table_options();
table_options.alter_with_string_hash_map(&cmd.options)?;
let aws_options =
table_options.extensions.get::<AwsOptions>().unwrap();
let builder =
@@ -540,7 +540,7 @@ mod tests {
if let LogicalPlan::Ddl(DdlStatement::CreateExternalTable(cmd)) = &mut
plan {
ctx.register_table_options_extension_from_scheme(scheme);
- let mut table_options =
ctx.state().default_table_options().clone();
+ let mut table_options = ctx.state().default_table_options();
table_options.alter_with_string_hash_map(&cmd.options)?;
let aws_options =
table_options.extensions.get::<AwsOptions>().unwrap();
let err = get_s3_object_store_builder(table_url.as_ref(),
aws_options)
@@ -566,7 +566,7 @@ mod tests {
if let LogicalPlan::Ddl(DdlStatement::CreateExternalTable(cmd)) = &mut
plan {
ctx.register_table_options_extension_from_scheme(scheme);
- let mut table_options =
ctx.state().default_table_options().clone();
+ let mut table_options = ctx.state().default_table_options();
table_options.alter_with_string_hash_map(&cmd.options)?;
let aws_options =
table_options.extensions.get::<AwsOptions>().unwrap();
// ensure this isn't an error
@@ -594,7 +594,7 @@ mod tests {
if let LogicalPlan::Ddl(DdlStatement::CreateExternalTable(cmd)) = &mut
plan {
ctx.register_table_options_extension_from_scheme(scheme);
- let mut table_options =
ctx.state().default_table_options().clone();
+ let mut table_options = ctx.state().default_table_options();
table_options.alter_with_string_hash_map(&cmd.options)?;
let aws_options =
table_options.extensions.get::<AwsOptions>().unwrap();
let builder = get_oss_object_store_builder(table_url.as_ref(),
aws_options)?;
@@ -631,7 +631,7 @@ mod tests {
if let LogicalPlan::Ddl(DdlStatement::CreateExternalTable(cmd)) = &mut
plan {
ctx.register_table_options_extension_from_scheme(scheme);
- let mut table_options =
ctx.state().default_table_options().clone();
+ let mut table_options = ctx.state().default_table_options();
table_options.alter_with_string_hash_map(&cmd.options)?;
let gcp_options =
table_options.extensions.get::<GcpOptions>().unwrap();
let builder = get_gcs_object_store_builder(table_url.as_ref(),
gcp_options)?;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
