This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 467a80481e Report offending plan node when In/Exist subquery misused
(#13155)
467a80481e is described below
commit 467a80481ec0d537a0bcc1feee43590babe67b66
Author: Piotr Findeisen <[email protected]>
AuthorDate: Tue Oct 29 12:21:50 2024 +0100
Report offending plan node when In/Exist subquery misused (#13155)
---
datafusion/optimizer/src/analyzer/subquery.rs | 4 +++-
datafusion/sqllogictest/test_files/subquery.slt | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/datafusion/optimizer/src/analyzer/subquery.rs
b/datafusion/optimizer/src/analyzer/subquery.rs
index e01ae625ed..7c0bddf115 100644
--- a/datafusion/optimizer/src/analyzer/subquery.rs
+++ b/datafusion/optimizer/src/analyzer/subquery.rs
@@ -113,7 +113,9 @@ pub fn check_subquery_expr(
| LogicalPlan::Join(_) => Ok(()),
_ => plan_err!(
"In/Exist subquery can only be used in \
- Projection, Filter, Window functions, Aggregate and Join plan
nodes"
+ Projection, Filter, Window functions, Aggregate and Join plan
nodes, \
+ but was used in [{}]",
+ outer_plan.display()
),
}?;
check_correlations_in_subquery(inner_plan)
diff --git a/datafusion/sqllogictest/test_files/subquery.slt
b/datafusion/sqllogictest/test_files/subquery.slt
index 26b5d8b952..36de19f1c3 100644
--- a/datafusion/sqllogictest/test_files/subquery.slt
+++ b/datafusion/sqllogictest/test_files/subquery.slt
@@ -438,7 +438,7 @@ SELECT t1_id, t1_name, t1_int, (select t2_id, t2_name FROM
t2 WHERE t2.t2_id = t
#subquery_not_allowed
#In/Exist Subquery is not allowed in ORDER BY clause.
-statement error DataFusion error: check_analyzed_plan\ncaused by\nError during
planning: In/Exist subquery can only be used in Projection, Filter, Window
functions, Aggregate and Join plan nodes
+statement error DataFusion error: check_analyzed_plan\ncaused by\nError during
planning: In/Exist subquery can only be used in Projection, Filter, Window
functions, Aggregate and Join plan nodes, but was used in \[Sort: t1.t1_int IN
\(<subquery>\) ASC NULLS LAST\]
SELECT t1_id, t1_name, t1_int FROM t1 order by t1_int in (SELECT t2_int FROM
t2 WHERE t1.t1_id > t1.t1_int)
#non_aggregated_correlated_scalar_subquery
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
