This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new fe14e778e1 Change trigger, rename `hash_collision.yml` to 
`extended.yml` and add comments (#13988)
fe14e778e1 is described below

commit fe14e778e1a9dc2ba02e09441d081246e49d9cd0
Author: Andrew Lamb <[email protected]>
AuthorDate: Fri Jan 3 06:04:17 2025 -0500

    Change trigger, rename `hash_collision.yml` to `extended.yml` and add 
comments (#13988)
    
    * Rename hash_collision.yml to extended.yml and add comments
    
    * Adjust schedule, add comments
    
    * Update job, rerun
---
 .github/workflows/{hash_collisions.yml => extended.yml} | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/hash_collisions.yml 
b/.github/workflows/extended.yml
similarity index 88%
rename from .github/workflows/hash_collisions.yml
rename to .github/workflows/extended.yml
index 908bec9d13..39efb7a845 100644
--- a/.github/workflows/hash_collisions.yml
+++ b/.github/workflows/extended.yml
@@ -23,13 +23,14 @@ concurrency:
 
 # 
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges
 #
-# this job is intended to only run on merge to main branch
+# this job is intended to only run only on the main branch as it is time 
consuming
+# and very rarely fails. However, it is important coverage to ensure 
correctness
+# in the (very rare) event of a hash failure.
 on:
-  pull_request:
+  # Run on all commits to main
+  push:
     branches:
       - main
-    types:
-      - closed
 
 jobs:
   # Check answers are correct when hash values collide
@@ -38,7 +39,6 @@ jobs:
     runs-on: ubuntu-latest
     container:
       image: amd64/rust
-    if: github.event.pull_request.merged == true
     steps:
       - uses: actions/checkout@v4
         with:


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to