This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new 4e877a08d2 refactor: make structs public and implement Default trait 
(#14030)
4e877a08d2 is described below

commit 4e877a08d224d992a8cbcc9a14f59468e312b13f
Author: Dharan Aditya <[email protected]>
AuthorDate: Tue Jan 7 03:24:17 2025 +0530

    refactor: make structs public and implement Default trait (#14030)
---
 datafusion/functions-nested/src/cardinality.rs | 8 +++++++-
 datafusion/functions-nested/src/dimension.rs   | 8 +++++++-
 datafusion/functions-nested/src/distance.rs    | 8 +++++++-
 datafusion/functions-nested/src/empty.rs       | 8 +++++++-
 datafusion/functions-nested/src/except.rs      | 8 +++++++-
 datafusion/functions-nested/src/extract.rs     | 8 +++++++-
 datafusion/functions-nested/src/map_extract.rs | 8 +++++++-
 datafusion/functions-nested/src/map_keys.rs    | 8 +++++++-
 datafusion/functions-nested/src/map_values.rs  | 6 ++++++
 datafusion/functions-nested/src/position.rs    | 8 +++++++-
 datafusion/functions-nested/src/range.rs       | 8 +++++++-
 datafusion/functions-nested/src/remove.rs      | 8 +++++++-
 datafusion/functions-nested/src/repeat.rs      | 8 +++++++-
 datafusion/functions-nested/src/replace.rs     | 8 +++++++-
 datafusion/functions-nested/src/resize.rs      | 8 +++++++-
 datafusion/functions-nested/src/reverse.rs     | 8 +++++++-
 datafusion/functions-nested/src/set_ops.rs     | 8 +++++++-
 datafusion/functions-nested/src/string.rs      | 8 +++++++-
 18 files changed, 125 insertions(+), 17 deletions(-)

diff --git a/datafusion/functions-nested/src/cardinality.rs 
b/datafusion/functions-nested/src/cardinality.rs
index b577e2aa9d..a46c5348d1 100644
--- a/datafusion/functions-nested/src/cardinality.rs
+++ b/datafusion/functions-nested/src/cardinality.rs
@@ -75,10 +75,16 @@ impl Cardinality {
     )
 )]
 #[derive(Debug)]
-pub(super) struct Cardinality {
+pub struct Cardinality {
     signature: Signature,
     aliases: Vec<String>,
 }
+
+impl Default for Cardinality {
+    fn default() -> Self {
+        Self::new()
+    }
+}
 impl ScalarUDFImpl for Cardinality {
     fn as_any(&self) -> &dyn Any {
         self
diff --git a/datafusion/functions-nested/src/dimension.rs 
b/datafusion/functions-nested/src/dimension.rs
index 9933bcf4a4..702d0fc3a7 100644
--- a/datafusion/functions-nested/src/dimension.rs
+++ b/datafusion/functions-nested/src/dimension.rs
@@ -61,11 +61,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayDims {
+pub struct ArrayDims {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayDims {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayDims {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/distance.rs 
b/datafusion/functions-nested/src/distance.rs
index 1f0d31f2e0..8559b1096b 100644
--- a/datafusion/functions-nested/src/distance.rs
+++ b/datafusion/functions-nested/src/distance.rs
@@ -67,11 +67,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayDistance {
+pub struct ArrayDistance {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayDistance {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayDistance {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/empty.rs 
b/datafusion/functions-nested/src/empty.rs
index ab205a7cd4..9739ffb15f 100644
--- a/datafusion/functions-nested/src/empty.rs
+++ b/datafusion/functions-nested/src/empty.rs
@@ -56,10 +56,16 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayEmpty {
+pub struct ArrayEmpty {
     signature: Signature,
     aliases: Vec<String>,
 }
+
+impl Default for ArrayEmpty {
+    fn default() -> Self {
+        Self::new()
+    }
+}
 impl ArrayEmpty {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/except.rs 
b/datafusion/functions-nested/src/except.rs
index 1bb5ffd5d3..356c92983a 100644
--- a/datafusion/functions-nested/src/except.rs
+++ b/datafusion/functions-nested/src/except.rs
@@ -67,11 +67,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayExcept {
+pub struct ArrayExcept {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayExcept {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayExcept {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/extract.rs 
b/datafusion/functions-nested/src/extract.rs
index d5b8b5d619..cce10d2bf6 100644
--- a/datafusion/functions-nested/src/extract.rs
+++ b/datafusion/functions-nested/src/extract.rs
@@ -102,11 +102,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayElement {
+pub struct ArrayElement {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayElement {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayElement {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/map_extract.rs 
b/datafusion/functions-nested/src/map_extract.rs
index 1ade3f67c9..8ccfae0ff9 100644
--- a/datafusion/functions-nested/src/map_extract.rs
+++ b/datafusion/functions-nested/src/map_extract.rs
@@ -72,11 +72,17 @@ SELECT map_extract(MAP {'x': 10, 'y': NULL, 'z': 30}, 'y');
     )
 )]
 #[derive(Debug)]
-pub(super) struct MapExtract {
+pub struct MapExtract {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for MapExtract {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl MapExtract {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/map_keys.rs 
b/datafusion/functions-nested/src/map_keys.rs
index d3afce3e40..74a106bb0c 100644
--- a/datafusion/functions-nested/src/map_keys.rs
+++ b/datafusion/functions-nested/src/map_keys.rs
@@ -56,10 +56,16 @@ SELECT map_keys(map([100, 5], [42, 43]));
     )
 )]
 #[derive(Debug)]
-pub(crate) struct MapKeysFunc {
+pub struct MapKeysFunc {
     signature: Signature,
 }
 
+impl Default for MapKeysFunc {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl MapKeysFunc {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/map_values.rs 
b/datafusion/functions-nested/src/map_values.rs
index fb3aec009f..d2fc0a12f9 100644
--- a/datafusion/functions-nested/src/map_values.rs
+++ b/datafusion/functions-nested/src/map_values.rs
@@ -60,6 +60,12 @@ pub(crate) struct MapValuesFunc {
     signature: Signature,
 }
 
+impl Default for MapValuesFunc {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl MapValuesFunc {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/position.rs 
b/datafusion/functions-nested/src/position.rs
index f56fdf734c..eec2a32fa2 100644
--- a/datafusion/functions-nested/src/position.rs
+++ b/datafusion/functions-nested/src/position.rs
@@ -76,10 +76,16 @@ make_udf_expr_and_func!(
     argument(name = "index", description = "Index at which to start 
searching.")
 )]
 #[derive(Debug)]
-pub(super) struct ArrayPosition {
+pub struct ArrayPosition {
     signature: Signature,
     aliases: Vec<String>,
 }
+
+impl Default for ArrayPosition {
+    fn default() -> Self {
+        Self::new()
+    }
+}
 impl ArrayPosition {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/range.rs 
b/datafusion/functions-nested/src/range.rs
index cf27c70c2b..27cf530418 100644
--- a/datafusion/functions-nested/src/range.rs
+++ b/datafusion/functions-nested/src/range.rs
@@ -89,10 +89,16 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct Range {
+pub struct Range {
     signature: Signature,
     aliases: Vec<String>,
 }
+
+impl Default for Range {
+    fn default() -> Self {
+        Self::new()
+    }
+}
 impl Range {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/remove.rs 
b/datafusion/functions-nested/src/remove.rs
index b6031ce733..bf7f474661 100644
--- a/datafusion/functions-nested/src/remove.rs
+++ b/datafusion/functions-nested/src/remove.rs
@@ -64,11 +64,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayRemove {
+pub struct ArrayRemove {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayRemove {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayRemove {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/repeat.rs 
b/datafusion/functions-nested/src/repeat.rs
index 498781f5b3..da0aa5f12f 100644
--- a/datafusion/functions-nested/src/repeat.rs
+++ b/datafusion/functions-nested/src/repeat.rs
@@ -72,11 +72,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayRepeat {
+pub struct ArrayRepeat {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayRepeat {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayRepeat {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/replace.rs 
b/datafusion/functions-nested/src/replace.rs
index 0902d1d036..0d3db07c64 100644
--- a/datafusion/functions-nested/src/replace.rs
+++ b/datafusion/functions-nested/src/replace.rs
@@ -78,11 +78,17 @@ make_udf_expr_and_func!(ArrayReplaceAll,
     argument(name = "to", description = "Final element.")
 )]
 #[derive(Debug)]
-pub(super) struct ArrayReplace {
+pub struct ArrayReplace {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayReplace {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayReplace {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/resize.rs 
b/datafusion/functions-nested/src/resize.rs
index 8a4a88741c..a2b95debd2 100644
--- a/datafusion/functions-nested/src/resize.rs
+++ b/datafusion/functions-nested/src/resize.rs
@@ -65,11 +65,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayResize {
+pub struct ArrayResize {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayResize {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayResize {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/reverse.rs 
b/datafusion/functions-nested/src/reverse.rs
index b394c1afea..8538ba5cac 100644
--- a/datafusion/functions-nested/src/reverse.rs
+++ b/datafusion/functions-nested/src/reverse.rs
@@ -58,11 +58,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayReverse {
+pub struct ArrayReverse {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayReverse {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayReverse {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/set_ops.rs 
b/datafusion/functions-nested/src/set_ops.rs
index 893fc933d0..70d69170fc 100644
--- a/datafusion/functions-nested/src/set_ops.rs
+++ b/datafusion/functions-nested/src/set_ops.rs
@@ -90,11 +90,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayUnion {
+pub struct ArrayUnion {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayUnion {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayUnion {
     pub fn new() -> Self {
         Self {
diff --git a/datafusion/functions-nested/src/string.rs 
b/datafusion/functions-nested/src/string.rs
index ee022053cf..7fc5e800e2 100644
--- a/datafusion/functions-nested/src/string.rs
+++ b/datafusion/functions-nested/src/string.rs
@@ -145,11 +145,17 @@ make_udf_expr_and_func!(
     )
 )]
 #[derive(Debug)]
-pub(super) struct ArrayToString {
+pub struct ArrayToString {
     signature: Signature,
     aliases: Vec<String>,
 }
 
+impl Default for ArrayToString {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl ArrayToString {
     pub fn new() -> Self {
         Self {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to