This is an automated email from the ASF dual-hosted git repository.

comphead pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new 05222720b8 Simplify Bloom Filter Check (#14165)
05222720b8 is described below

commit 05222720b8bd330c21e3f93d4e2b76813a62d779
Author: Andrew Lamb <[email protected]>
AuthorDate: Fri Jan 17 16:53:17 2025 -0500

    Simplify Bloom Filter Check (#14165)
---
 .../physical_plan/parquet/row_group_filter.rs        | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git 
a/datafusion/core/src/datasource/physical_plan/parquet/row_group_filter.rs 
b/datafusion/core/src/datasource/physical_plan/parquet/row_group_filter.rs
index 7658663be5..39d86fe857 100644
--- a/datafusion/core/src/datasource/physical_plan/parquet/row_group_filter.rs
+++ b/datafusion/core/src/datasource/physical_plan/parquet/row_group_filter.rs
@@ -294,23 +294,9 @@ impl BloomFilterStatistics {
                 }
                 _ => true,
             },
-            // One more pattern matching since not all data types are supported
-            // inside of a Dictionary
-            ScalarValue::Dictionary(_, inner) => match inner.as_ref() {
-                ScalarValue::Int32(_)
-                | ScalarValue::Int64(_)
-                | ScalarValue::UInt32(_)
-                | ScalarValue::UInt64(_)
-                | ScalarValue::Float32(_)
-                | ScalarValue::Float64(_)
-                | ScalarValue::Utf8(_)
-                | ScalarValue::LargeUtf8(_)
-                | ScalarValue::Binary(_)
-                | ScalarValue::LargeBinary(_) => {
-                    BloomFilterStatistics::check_scalar(sbbf, inner, 
parquet_type)
-                }
-                _ => true,
-            },
+            ScalarValue::Dictionary(_, inner) => {
+                BloomFilterStatistics::check_scalar(sbbf, inner, parquet_type)
+            }
             _ => true,
         }
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to