This is an automated email from the ASF dual-hosted git repository.
milenkovicm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-ballista.git
The following commit(s) were added to refs/heads/main by this push:
new 1db904b7 bug: build fails with `--no-default-features` (#1255)
1db904b7 is described below
commit 1db904b7633e3f7d2743c60e3a9ed5cf5392738b
Author: Marko Milenković <[email protected]>
AuthorDate: Tue Apr 29 09:51:52 2025 +0100
bug: build fails with `--no-default-features` (#1255)
---
.github/workflows/rust.yml | 9 +++++++++
ballista/scheduler/src/cluster/mod.rs | 7 ++++---
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 68ad936a..a6cb364d 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -121,6 +121,15 @@ jobs:
env:
CARGO_HOME: "/github/home/.cargo"
CARGO_TARGET_DIR: "/github/home/target"
+ - name: Try to compile when `--no-default-features` is selected
+ run: |
+ export PATH=$PATH:$HOME/d/protoc/bin
+ export ARROW_TEST_DATA=$(pwd)/testing/data
+ export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
+ cargo build -p ballista-scheduler -p ballista-executor -p
ballista-core -p ballista --no-default-features
+ env:
+ CARGO_HOME: "/github/home/.cargo"
+ CARGO_TARGET_DIR: "/github/home/target"
# run ballista tests
ballista-test:
diff --git a/ballista/scheduler/src/cluster/mod.rs
b/ballista/scheduler/src/cluster/mod.rs
index 6ca8884f..e1068474 100644
--- a/ballista/scheduler/src/cluster/mod.rs
+++ b/ballista/scheduler/src/cluster/mod.rs
@@ -19,7 +19,6 @@ use std::collections::{HashMap, HashSet};
use std::pin::Pin;
use std::sync::Arc;
-use clap::ValueEnum;
use datafusion::common::tree_node::TreeNode;
use datafusion::common::tree_node::TreeNodeRecursion;
use datafusion::datasource::listing::PartitionedFile;
@@ -57,16 +56,18 @@ pub mod test_util;
// an enum used to configure the backend
// needs to be visible to code generated by configure_me
-#[derive(Debug, Clone, ValueEnum, serde::Deserialize, PartialEq, Eq)]
+#[derive(Debug, Clone, serde::Deserialize, PartialEq, Eq)]
+#[cfg_attr(feature = "build-binary", derive(clap::ValueEnum))]
pub enum ClusterStorage {
Memory,
}
+#[cfg(feature = "build-binary")]
impl std::str::FromStr for ClusterStorage {
type Err = String;
fn from_str(s: &str) -> std::result::Result<Self, Self::Err> {
- ValueEnum::from_str(s, true)
+ clap::ValueEnum::from_str(s, true)
}
}
#[cfg(feature = "build-binary")]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
