This is an automated email from the ASF dual-hosted git repository.
milenkovicm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-ballista.git
The following commit(s) were added to refs/heads/main by this push:
new e1a4f55c fix: fix tests failing on windows (#1273)
e1a4f55c is described below
commit e1a4f55c2a43db1a2a1a4c59990ea4444e491a92
Author: Huy1Ng <huy.nguyen7994+git...@gmail.com>
AuthorDate: Tue Jun 17 02:25:49 2025 +0700
fix: fix tests failing on windows (#1273)
* explicitly create temp path
* enable windows tests
* set temp to correct job
* remove arrow lint test
---
.github/workflows/dev.yml | 19 -------------------
.github/workflows/rust.yml | 2 ++
ballista/client/tests/context_checks.rs | 4 ----
3 files changed, 2 insertions(+), 23 deletions(-)
diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml
index 2c02c0b8..84950373 100644
--- a/.github/workflows/dev.yml
+++ b/.github/workflows/dev.yml
@@ -19,25 +19,6 @@ name: Dev
on: [push, pull_request]
jobs:
- lint:
- name: Lint C++, Python, R, Rust, Docker
- runs-on: ubuntu-latest
- steps:
- - name: Checkout Arrow
- uses: actions/checkout@v4
- with:
- repository: apache/arrow
- submodules: true
- fetch-depth: 0
- - name: Setup Python
- uses: actions/setup-python@v4
- with:
- python-version: "3.10"
- - name: Setup Archery
- run: pip install -e dev/archery[lint]
- - name: Lint
- run: archery lint --rat
-
rat:
name: Release Audit Tool (RAT)
runs-on: ubuntu-latest
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index a6cb364d..c056f5e9 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -236,6 +236,8 @@ jobs:
export PATH=$PATH:$HOME/d/protoc/bin
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
+ export TMP=$(pwd)/.temp
+ mkdir -p "$TMP"
cargo test
env:
# do not produce debug symbols to keep memory usage down
diff --git a/ballista/client/tests/context_checks.rs
b/ballista/client/tests/context_checks.rs
index edb1e73b..6a1abe40 100644
--- a/ballista/client/tests/context_checks.rs
+++ b/ballista/client/tests/context_checks.rs
@@ -132,7 +132,6 @@ mod supported {
#[case::standalone(standalone_context())]
#[case::remote(remote_context())]
#[tokio::test]
- #[cfg(not(windows))] // test is failing at windows, can't debug it
async fn should_collect_client_statistics_for_insert(
#[future(awt)]
#[case]
@@ -399,7 +398,6 @@ mod supported {
#[case::standalone(standalone_context())]
#[case::remote(remote_context())]
#[tokio::test]
- #[cfg(not(windows))] // test is failing at windows, can't debug it
async fn should_execute_sql_write(
#[future(awt)]
#[case]
@@ -557,7 +555,6 @@ mod supported {
#[case::standalone(standalone_context())]
#[case::remote(remote_context())]
#[tokio::test]
- #[cfg(not(windows))] // test is failing at windows, can't debug it
async fn should_support_sql_insert_into(
#[future(awt)]
#[case]
@@ -619,7 +616,6 @@ mod supported {
#[case::standalone_state(standalone_context_with_state())]
#[case::remote_state(remote_context_with_state())]
#[tokio::test]
- #[cfg(not(windows))] // test is failing at windows, can't debug it
async fn should_execute_sql_write_read_roundtrip(
#[future(awt)]
#[case]
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@datafusion.apache.org
For additional commands, e-mail: commits-h...@datafusion.apache.org
