This is an automated email from the ASF dual-hosted git repository. xudong963 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push: new e6df27c3ba . (#16449) e6df27c3ba is described below commit e6df27c3ba49b32fef0689c87cb787d2f6948939 Author: Adam Gutglick <a...@spiraldb.com> AuthorDate: Thu Jun 19 11:15:55 2025 +0100 . (#16449) --- datafusion/physical-plan/Cargo.toml | 2 -- .../physical-plan/benches/sort_preserving_merge.rs | 21 ++++++++------------- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/datafusion/physical-plan/Cargo.toml b/datafusion/physical-plan/Cargo.toml index 4f58b575f3..0fc68ae497 100644 --- a/datafusion/physical-plan/Cargo.toml +++ b/datafusion/physical-plan/Cargo.toml @@ -36,7 +36,6 @@ workspace = true [features] force_hash_collisions = [] -bench = [] [lib] name = "datafusion_physical_plan" @@ -91,4 +90,3 @@ name = "spill_io" [[bench]] harness = false name = "sort_preserving_merge" -required-features = ["bench"] diff --git a/datafusion/physical-plan/benches/sort_preserving_merge.rs b/datafusion/physical-plan/benches/sort_preserving_merge.rs index 9586dbf947..f223fd806b 100644 --- a/datafusion/physical-plan/benches/sort_preserving_merge.rs +++ b/datafusion/physical-plan/benches/sort_preserving_merge.rs @@ -115,18 +115,13 @@ fn get_bench_data() -> Vec<BenchData> { let mut push_bench_data = |bench_name: &str, partitions: Vec<Vec<RecordBatch>>| { let schema = partitions[0][0].schema(); // Define sort order (col1 ASC, col2 ASC, col3 ASC) - let sort_order = LexOrdering::new( - schema - .fields() - .iter() - .map(|field| { - PhysicalSortExpr::new( - col(field.name(), &schema).unwrap(), - SortOptions::default(), - ) - }) - .collect(), - ); + let sort_order = LexOrdering::new(schema.fields().iter().map(|field| { + PhysicalSortExpr::new( + col(field.name(), &schema).unwrap(), + SortOptions::default(), + ) + })) + .unwrap(); ret.push(BenchData { bench_name: bench_name.to_string(), partitions, @@ -173,7 +168,7 @@ fn bench_merge_sorted_preserving(c: &mut Criterion) { sort_order, } = data; c.bench_function( - &format!("bench_merge_sorted_preserving/{}", bench_name), + &format!("bench_merge_sorted_preserving/{bench_name}"), |b| { b.iter_batched( || { --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@datafusion.apache.org For additional commands, e-mail: commits-h...@datafusion.apache.org