This is an automated email from the ASF dual-hosted git repository.

comphead pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new 334d449ff7 Minor: Add documentation to 
`AggregateWindowExpr::get_result_column` (#16479)
334d449ff7 is described below

commit 334d449ff778af590a7d8421544ac60222e5f69b
Author: Andrew Lamb <and...@nerdnetworks.org>
AuthorDate: Tue Jun 24 18:24:07 2025 -0400

    Minor: Add documentation to `AggregateWindowExpr::get_result_column` 
(#16479)
    
    * Minor: Add documentation to `AggregateWindowExpr::get_result_column`
    
    * Update datafusion/physical-expr/src/window/window_expr.rs
---
 datafusion/physical-expr/src/window/window_expr.rs | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/datafusion/physical-expr/src/window/window_expr.rs 
b/datafusion/physical-expr/src/window/window_expr.rs
index d994e8be1d..dd671e0685 100644
--- a/datafusion/physical-expr/src/window/window_expr.rs
+++ b/datafusion/physical-expr/src/window/window_expr.rs
@@ -263,6 +263,15 @@ pub trait AggregateWindowExpr: WindowExpr {
 
     /// Calculates the window expression result for the given record batch.
     /// Assumes that `record_batch` belongs to a single partition.
+    ///
+    /// # Arguments
+    /// * `accumulator`: The accumulator to use for the calculation.
+    /// * `record_batch`: batch belonging to the current partition (see 
[`PartitionBatchState`]).
+    /// * `most_recent_row`: the batch that contains the most recent row, if 
available (see [`PartitionBatchState`]).
+    /// * `last_range`: The last range of rows that were processed (see 
[`WindowAggState`]).
+    /// * `window_frame_ctx`: Details about the window frame (see 
[`WindowFrameContext`]).
+    /// * `idx`: The index of the current row in the record batch.
+    /// * `not_end`: is the current row not the end of the partition (see 
[`PartitionBatchState`]).
     #[allow(clippy::too_many_arguments)]
     fn get_result_column(
         &self,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@datafusion.apache.org
For additional commands, e-mail: commits-h...@datafusion.apache.org

Reply via email to