This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new 2afb68106f Fix sqllogictests test running compatibility (ignore 
`--test-threads`) (#16694)
2afb68106f is described below

commit 2afb68106fcbc3d4590c81b98c0581fce32f228a
Author: Martin Garton <[email protected]>
AuthorDate: Tue Jul 8 22:46:18 2025 +0100

    Fix sqllogictests test running compatibility (ignore `--test-threads`) 
(#16694)
    
    * Fix test running compatibility
    
    sqllogictests.rs already has various parts of it's Options struct that
    provide compatibility with the standard test running options.
    
    Extend this to include the standard `--test-threads` option, so that
    running for example `cargo test -- --test-threads 1` in the project root
    will succeed.  Previously it complained about the unknown option.
    
    This can be useful on a machine with a large number of cores which causes
    many tests to build & run in parallel, which in my case caused a crash
    due to exhausing the system RAM.
    
    * Make test-threads optional
    
    Make test-threads optional, so that the tests also pass when this is not
    passed in. 🤦
---
 datafusion/sqllogictest/bin/sqllogictests.rs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/datafusion/sqllogictest/bin/sqllogictests.rs 
b/datafusion/sqllogictest/bin/sqllogictests.rs
index d5fce1a7cd..eebd7bdf66 100644
--- a/datafusion/sqllogictest/bin/sqllogictests.rs
+++ b/datafusion/sqllogictest/bin/sqllogictests.rs
@@ -689,6 +689,12 @@ struct Options {
         help = "IGNORED (for compatibility with built-in rust test runner)"
     )]
     nocapture: bool,
+
+    #[clap(
+        long,
+        help = "IGNORED (for compatibility with built-in rust test runner)"
+    )]
+    test_threads: Option<usize>,
 }
 
 impl Options {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to