This is an automated email from the ASF dual-hosted git repository.
agrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new bce3c06fa remove check for custom endpoints (#2288)
bce3c06fa is described below
commit bce3c06fad39be93dbc403ae5cb89d81e3b1f17e
Author: Andy Grove <agr...@apache.org>
AuthorDate: Tue Sep 2 19:35:12 2025 -0600
remove check for custom endpoints (#2288)
---
native/core/src/parquet/objectstore/s3.rs | 6 ------
.../org/apache/comet/objectstore/NativeConfigSuite.scala | 11 -----------
2 files changed, 17 deletions(-)
diff --git a/native/core/src/parquet/objectstore/s3.rs
b/native/core/src/parquet/objectstore/s3.rs
index 390f79955..cc257bb82 100644
--- a/native/core/src/parquet/objectstore/s3.rs
+++ b/native/core/src/parquet/objectstore/s3.rs
@@ -68,12 +68,6 @@ pub fn create_store(
}
let path = Path::parse(path)?;
- if configs.contains_key("fs.s3a.endpoint") {
- return Err(object_store::Error::NotSupported {
- source: "Custom S3 endpoints are not supported".into(),
- });
- }
-
let mut builder = AmazonS3Builder::new()
.with_url(url.to_string())
.with_allow_http(true);
diff --git
a/spark/src/test/scala/org/apache/comet/objectstore/NativeConfigSuite.scala
b/spark/src/test/scala/org/apache/comet/objectstore/NativeConfigSuite.scala
index 3560a437d..7cd1ca312 100644
--- a/spark/src/test/scala/org/apache/comet/objectstore/NativeConfigSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/objectstore/NativeConfigSuite.scala
@@ -117,17 +117,6 @@ class NativeConfigSuite extends AnyFunSuite with Matchers
with BeforeAndAfterEac
assert(e.getMessage.contains(expectedError))
}
- test("validate object store config - custom s3 endpoint not supported") {
- val hadoopConf = new Configuration()
- hadoopConf.set("fs.s3a.endpoint", "https://acme.storage.com";)
- val e = intercept[CometNativeException] {
- validate(hadoopConf)
- }
- val expectedError =
- "Custom S3 endpoints are not supported"
- assert(e.getMessage.contains(expectedError))
- }
-
test("validity cache") {
val hadoopConf = new Configuration()
hadoopConf.set("fs.s3a.endpoint", "https://acme.storage.com";)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@datafusion.apache.org
For additional commands, e-mail: commits-h...@datafusion.apache.org
