This is an automated email from the ASF dual-hosted git repository.
agrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new e684cf8e2 Enable plan stability tests (#2516)
e684cf8e2 is described below
commit e684cf8e24884045d731369323dcff92465a0e2f
Author: Andy Grove <[email protected]>
AuthorDate: Thu Oct 2 12:55:39 2025 -0600
Enable plan stability tests (#2516)
---
.../spark/sql/comet/CometPlanStabilitySuite.scala | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git
a/spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala
b/spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala
index 0b4ec1280..028e45dee 100644
---
a/spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala
+++
b/spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala
@@ -248,6 +248,7 @@ trait CometPlanStabilitySuite extends
DisableAdaptiveExecutionSuite with TPCDSBa
CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.key -> "true",
CometConf.COMET_ENABLED.key -> "true",
CometConf.COMET_NATIVE_SCAN_ENABLED.key -> "true",
+ CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_AUTO,
CometConf.COMET_EXEC_ENABLED.key -> "true",
CometConf.COMET_DPP_FALLBACK_ENABLED.key -> "false",
CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true",
@@ -283,8 +284,6 @@ trait CometPlanStabilitySuite extends
DisableAdaptiveExecutionSuite with TPCDSBa
conf.set(MEMORY_OFFHEAP_SIZE.key, "2g")
conf.set(CometConf.COMET_ENABLED.key, "true")
conf.set(CometConf.COMET_EXEC_ENABLED.key, "true")
- conf.set(CometConf.COMET_NATIVE_SCAN_ENABLED.key, "true")
- conf.set(CometConf.COMET_NATIVE_SCAN_IMPL.key, CometConf.SCAN_AUTO)
conf.set(CometConf.COMET_MEMORY_OVERHEAD.key, "1g")
conf.set(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key, "true")
@@ -303,11 +302,9 @@ class CometTPCDSV1_4_PlanStabilitySuite extends
CometPlanStabilitySuite {
override val goldenFilePath: String =
new File(baseResourcePath, planName).getAbsolutePath
- if (CometConf.COMET_NATIVE_SCAN_IMPL.get() == CometConf.SCAN_AUTO) {
- tpcdsQueries.foreach { q =>
- test(s"check simplified (tpcds-v1.4/$q)") {
- testQuery("tpcds", q)
- }
+ tpcdsQueries.foreach { q =>
+ test(s"check simplified (tpcds-v1.4/$q)") {
+ testQuery("tpcds", q)
}
}
}
@@ -323,11 +320,9 @@ class CometTPCDSV2_7_PlanStabilitySuite extends
CometPlanStabilitySuite {
override val goldenFilePath: String =
new File(baseResourcePath, planName).getAbsolutePath
- if (CometConf.COMET_NATIVE_SCAN_IMPL.get() == CometConf.SCAN_AUTO) {
- tpcdsQueriesV2_7_0.foreach { q =>
- test(s"check simplified (tpcds-v2.7.0/$q)") {
- testQuery("tpcds-v2.7.0", q)
- }
+ tpcdsQueriesV2_7_0.foreach { q =>
+ test(s"check simplified (tpcds-v2.7.0/$q)") {
+ testQuery("tpcds-v2.7.0", q)
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
