This is an automated email from the ASF dual-hosted git repository.
agrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new cd29597ab build: Run scala tests against release build of native code
(#2541)
cd29597ab is described below
commit cd29597ab9f7a788a2b12a1f5b3ecfd950ecaecb
Author: Andy Grove <[email protected]>
AuthorDate: Fri Oct 10 09:04:30 2025 -0600
build: Run scala tests against release build of native code (#2541)
---
.github/actions/java-test/action.yaml | 10 ++++++----
.../src/test/scala/org/apache/comet/CometExpressionSuite.scala | 3 ++-
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/.github/actions/java-test/action.yaml
b/.github/actions/java-test/action.yaml
index 1f7899f8a..5afb52033 100644
--- a/.github/actions/java-test/action.yaml
+++ b/.github/actions/java-test/action.yaml
@@ -41,11 +41,13 @@ inputs:
runs:
using: "composite"
steps:
- - name: Run Cargo build
+ - name: Run Cargo release build
shell: bash
+ # it is important that we run the Scala tests against a release build
rather than a debug build
+ # to make sure that no tests are relying on overflow checks that are
present only in debug builds
run: |
cd native
- cargo build
+ cargo build --release
- name: Cache Maven dependencies
uses: actions/cache@v4
@@ -70,7 +72,7 @@ runs:
SPARK_LOCAL_HOSTNAME: "localhost"
SPARK_LOCAL_IP: "127.0.0.1"
run: |
- MAVEN_OPTS="-Xmx4G -Xms2G -XX:+UnlockDiagnosticVMOptions
-XX:+ShowMessageBoxOnError -XX:+HeapDumpOnOutOfMemoryError
-XX:ErrorFile=./hs_err_pid%p.log" SPARK_HOME=`pwd` ./mvnw -B clean install ${{
inputs.maven_opts }}
+ MAVEN_OPTS="-Xmx4G -Xms2G -XX:+UnlockDiagnosticVMOptions
-XX:+ShowMessageBoxOnError -XX:+HeapDumpOnOutOfMemoryError
-XX:ErrorFile=./hs_err_pid%p.log" SPARK_HOME=`pwd` ./mvnw -B -Prelease clean
install ${{ inputs.maven_opts }}
- name: Run specified tests
shell: bash
if: ${{ inputs.suites != '' }}
@@ -81,7 +83,7 @@ runs:
run: |
MAVEN_SUITES="$(echo "${{ inputs.suites }}" | paste -sd, -)"
echo "Running with MAVEN_SUITES=$MAVEN_SUITES"
- MAVEN_OPTS="-Xmx4G -Xms2G -DwildcardSuites=$MAVEN_SUITES
-XX:+UnlockDiagnosticVMOptions -XX:+ShowMessageBoxOnError
-XX:+HeapDumpOnOutOfMemoryError -XX:ErrorFile=./hs_err_pid%p.log"
SPARK_HOME=`pwd` ./mvnw -B clean install ${{ inputs.maven_opts }}
+ MAVEN_OPTS="-Xmx4G -Xms2G -DwildcardSuites=$MAVEN_SUITES
-XX:+UnlockDiagnosticVMOptions -XX:+ShowMessageBoxOnError
-XX:+HeapDumpOnOutOfMemoryError -XX:ErrorFile=./hs_err_pid%p.log"
SPARK_HOME=`pwd` ./mvnw -B -Prelease clean install ${{ inputs.maven_opts }}
- name: Upload crash logs
if: failure()
uses: actions/upload-artifact@v4
diff --git a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
index f391d52f7..01c23f576 100644
--- a/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
@@ -239,7 +239,8 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
- test("date_add with scalar overflow") {
+ // TODO: https://github.com/apache/datafusion-comet/issues/2539
+ ignore("date_add with scalar overflow") {
Seq(true, false).foreach { dictionaryEnabled =>
withTempDir { dir =>
val path = new Path(dir.toURI.toString, "test.parquet")
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
