This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new a45192084e chore: remove dialect settings in SLT tests that are
outdated (#17807)
a45192084e is described below
commit a45192084e95a2d629b7cbf88b43133d8d6fb814
Author: Jeffrey Vo <[email protected]>
AuthorDate: Mon Sep 29 13:43:14 2025 +1000
chore: remove dialect settings in SLT tests that are outdated (#17807)
---
datafusion/sqllogictest/test_files/aggregate.slt | 16 ----------------
.../sqllogictest/test_files/aggregate_skip_partial.slt | 7 -------
datafusion/sqllogictest/test_files/create_function.slt | 5 -----
datafusion/sqllogictest/test_files/expr.slt | 6 ------
datafusion/sqllogictest/test_files/group_by.slt | 8 --------
5 files changed, 42 deletions(-)
diff --git a/datafusion/sqllogictest/test_files/aggregate.slt
b/datafusion/sqllogictest/test_files/aggregate.slt
index 2b4daff9e6..9d6c7b11ad 100644
--- a/datafusion/sqllogictest/test_files/aggregate.slt
+++ b/datafusion/sqllogictest/test_files/aggregate.slt
@@ -725,10 +725,6 @@ SELECT c2, var_samp(c12) FROM aggregate_test_100 WHERE c12
> 0.90 GROUP BY c2 OR
4 NULL
5 0.000269544643
-# Use PostgresSQL dialect
-statement ok
-set datafusion.sql_parser.dialect = 'Postgres';
-
# csv_query_stddev_12
query IR
SELECT c2, var_samp(c12) FILTER (WHERE c12 > 0.95) FROM aggregate_test_100
GROUP BY c2 ORDER BY c2
@@ -764,10 +760,6 @@ WITH s AS (
statement ok
DROP TABLE t
-# Restore the default dialect
-statement ok
-set datafusion.sql_parser.dialect = 'Generic';
-
# csv_query_stddev_13
query IR
SELECT c2, var_samp(CASE WHEN c12 > 0.90 THEN c12 ELSE null END) FROM
aggregate_test_100 GROUP BY c2 ORDER BY c2
@@ -5197,10 +5189,6 @@ select c2, count(DISTINCT cast(c1 AS DECIMAL(10, 2)))
from d_table GROUP BY c2 O
A 2
B 2
-# Use PostgresSQL dialect
-statement ok
-set datafusion.sql_parser.dialect = 'Postgres';
-
# Creating the table
statement ok
CREATE TABLE test_table (c1 INT, c2 INT, c3 INT)
@@ -5330,10 +5318,6 @@ select c3, count(c2), avg(c2), sum(c2), min(c2),
max(c2), count(c4), sum(c4) fro
700.1 2 15.15 30.3 10.1 20.2 0 NULL
NULL 1 10.1 10.1 10.1 10.1 0 NULL
-# Restore the default dialect
-statement ok
-set datafusion.sql_parser.dialect = 'Generic';
-
## Multiple distinct aggregates and dictionaries
statement ok
create table dict_test as values (1, arrow_cast('foo', 'Dictionary(Int32,
Utf8)')), (1, arrow_cast('foo', 'Dictionary(Int32, Utf8)')), (2,
arrow_cast('bar', 'Dictionary(Int32, Utf8)')), (1, arrow_cast('bar',
'Dictionary(Int32, Utf8)'));
diff --git a/datafusion/sqllogictest/test_files/aggregate_skip_partial.slt
b/datafusion/sqllogictest/test_files/aggregate_skip_partial.slt
index 8755918cd1..5dcb72b705 100644
--- a/datafusion/sqllogictest/test_files/aggregate_skip_partial.slt
+++ b/datafusion/sqllogictest/test_files/aggregate_skip_partial.slt
@@ -69,9 +69,6 @@ set datafusion.execution.target_partitions = 2;
statement ok
set datafusion.execution.batch_size = 1;
-statement ok
-set datafusion.sql_parser.dialect = 'Postgres';
-
# Grouping by unique fields allows to check all accumulators
query ITIIII
SELECT c5, c1,
@@ -420,10 +417,6 @@ c true false NULL
d NULL false NULL
e true false NULL
-# Enabling PG dialect for filtered aggregates tests
-statement ok
-set datafusion.sql_parser.dialect = 'Postgres';
-
# Test count with filter
query III
SELECT
diff --git a/datafusion/sqllogictest/test_files/create_function.slt
b/datafusion/sqllogictest/test_files/create_function.slt
index 4f0c53c36c..4e82c0866e 100644
--- a/datafusion/sqllogictest/test_files/create_function.slt
+++ b/datafusion/sqllogictest/test_files/create_function.slt
@@ -21,11 +21,6 @@
## Note that DataFusion provides a pluggable system for creating functions
## but has no built in support for doing so.
-# Use PostgresSQL dialect (until we upgrade to sqlparser 0.44, where CREATE
FUNCTION)
-# is supported in the Generic dialect (the default)
-statement ok
-set datafusion.sql_parser.dialect = 'Postgres';
-
# Create function will fail unless a user supplied function factory is supplied
statement error DataFusion error: Invalid or Unsupported Configuration:
Function factory has not been configured
CREATE FUNCTION foo (DOUBLE) RETURNS DOUBLE RETURN $1 + $2;
diff --git a/datafusion/sqllogictest/test_files/expr.slt
b/datafusion/sqllogictest/test_files/expr.slt
index eeea3cd39a..87345b833e 100644
--- a/datafusion/sqllogictest/test_files/expr.slt
+++ b/datafusion/sqllogictest/test_files/expr.slt
@@ -2079,9 +2079,6 @@ host1 1.1 101
host2 2.2 202
host3 3.3 303
-statement ok
-set datafusion.sql_parser.dialect = 'Postgres';
-
statement ok
create table t (a float) as values (1), (2), (3);
@@ -2101,9 +2098,6 @@ physical_plan
statement ok
drop table t;
-statement ok
-set datafusion.sql_parser.dialect = 'Generic';
-
# test between expression with null
query I
select 1 where null between null and null;
diff --git a/datafusion/sqllogictest/test_files/group_by.slt
b/datafusion/sqllogictest/test_files/group_by.slt
index 1b5ea3df2c..b72f73d446 100644
--- a/datafusion/sqllogictest/test_files/group_by.slt
+++ b/datafusion/sqllogictest/test_files/group_by.slt
@@ -4475,10 +4475,6 @@ physical_plan
12)----------------------RepartitionExec: partitioning=RoundRobinBatch(8),
input_partitions=1
13)------------------------DataSourceExec: file_groups={1 group:
[[WORKSPACE_ROOT/testing/data/csv/aggregate_test_100.csv]]}, projection=[c1,
c2, c3, c4], file_type=csv, has_header=true
-# Use PostgreSQL dialect
-statement ok
-set datafusion.sql_parser.dialect = 'Postgres';
-
query II
SELECT c2, count(distinct c3) FILTER (WHERE c1 != 'a') FROM aggregate_test_100
GROUP BY c2 ORDER BY c2;
----
@@ -4497,10 +4493,6 @@ SELECT c2, count(distinct c3) FILTER (WHERE c1 != 'a'),
count(c5) FILTER (WHERE
4 19 18
5 11 9
-# Restore the default dialect
-statement ok
-set datafusion.sql_parser.dialect = 'Generic';
-
statement ok
drop table aggregate_test_100;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
