This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new d679b3be4f Fix an out of date comment for `snapshot_physical_expr`
(#18498)
d679b3be4f is described below
commit d679b3be4f7a0943dde5e58aa191b1d72fad648c
Author: Adam Gutglick <[email protected]>
AuthorDate: Wed Nov 5 20:09:24 2025 +0000
Fix an out of date comment for `snapshot_physical_expr` (#18498)
## Which issue does this PR close?
- Closes https://github.com/apache/datafusion/issues/18497
## Rationale for this change
Better docs
## What changes are included in this PR?
Docs clarifications
## Are these changes tested?
N/A
## Are there any user-facing changes?
No
---
datafusion/physical-expr-common/src/physical_expr.rs | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/datafusion/physical-expr-common/src/physical_expr.rs
b/datafusion/physical-expr-common/src/physical_expr.rs
index 492383663d..e8280409c0 100644
--- a/datafusion/physical-expr-common/src/physical_expr.rs
+++ b/datafusion/physical-expr-common/src/physical_expr.rs
@@ -565,9 +565,8 @@ pub fn fmt_sql(expr: &dyn PhysicalExpr) -> impl Display +
'_ {
///
/// # Returns
///
-/// Returns an `Option<Arc<dyn PhysicalExpr>>` which is the snapshot of the
-/// `PhysicalExpr` if it is dynamic. If the `PhysicalExpr` does not have
-/// any dynamic references or state, it returns `None`.
+/// Returns a snapshot of the `PhysicalExpr` if it is dynamic, otherwise
+/// returns itself.
pub fn snapshot_physical_expr(
expr: Arc<dyn PhysicalExpr>,
) -> Result<Arc<dyn PhysicalExpr>> {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
