This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 3e2972ae13 chore: Enforce lint rule `clippy::needless_pass_by_value`
to `datafusion-catalog` (#18638)
3e2972ae13 is described below
commit 3e2972ae13e035741b63a29256cf748a7a558cde
Author: Alan Tang <[email protected]>
AuthorDate: Thu Nov 13 17:45:43 2025 +0800
chore: Enforce lint rule `clippy::needless_pass_by_value` to
`datafusion-catalog` (#18638)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #18609.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
The type `impl AsRef<str>` is implicitly `Sized`, meaning its size is
known at compile time.
`&(impl AsRef<str>)` is a reference to a concrete type that implements
`AsRef<str>` and is `Sized`. However, this `Sized` bound prevents
passing references to dynamically sized types such as `&str`, `String`,
or `Box<dyn Trait>`.
Therefore, we add `+ ?Sized` to indicate that the referenced type might
not have a fixed size — that is, it allows the referenced type to be
dynamically sized.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
- Enforce lint rule `clippy::needless_pass_by_value` to
`datafusion-catalog`.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Signed-off-by: Alan Tang <[email protected]>
---
datafusion/catalog/src/information_schema.rs | 24 ++++++++++++------------
datafusion/catalog/src/lib.rs | 2 ++
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/datafusion/catalog/src/information_schema.rs
b/datafusion/catalog/src/information_schema.rs
index d733551f44..526a1f0446 100644
--- a/datafusion/catalog/src/information_schema.rs
+++ b/datafusion/catalog/src/information_schema.rs
@@ -245,7 +245,7 @@ impl InformationSchemaConfig {
name,
"FUNCTION",
Self::is_deterministic(udf.signature()),
- return_type,
+ return_type.as_ref(),
"SCALAR",
udf.documentation().map(|d| d.description.to_string()),
udf.documentation().map(|d| d.syntax_example.to_string()),
@@ -265,7 +265,7 @@ impl InformationSchemaConfig {
name,
"FUNCTION",
Self::is_deterministic(udaf.signature()),
- return_type,
+ return_type.as_ref(),
"AGGREGATE",
udaf.documentation().map(|d| d.description.to_string()),
udaf.documentation().map(|d| d.syntax_example.to_string()),
@@ -285,7 +285,7 @@ impl InformationSchemaConfig {
name,
"FUNCTION",
Self::is_deterministic(udwf.signature()),
- return_type,
+ return_type.as_ref(),
"WINDOW",
udwf.documentation().map(|d| d.description.to_string()),
udwf.documentation().map(|d| d.syntax_example.to_string()),
@@ -418,11 +418,11 @@ fn get_udf_args_and_return_types(
// only handle the function which implemented
[`ScalarUDFImpl::return_type`] method
let return_type = udf
.return_type(&arg_types)
- .map(|t| remove_native_type_prefix(NativeType::from(t)))
+ .map(|t| remove_native_type_prefix(&NativeType::from(t)))
.ok();
let arg_types = arg_types
.into_iter()
- .map(|t| remove_native_type_prefix(NativeType::from(t)))
+ .map(|t| remove_native_type_prefix(&NativeType::from(t)))
.collect::<Vec<_>>();
(arg_types, return_type)
})
@@ -445,10 +445,10 @@ fn get_udaf_args_and_return_types(
let return_type = udaf
.return_type(&arg_types)
.ok()
- .map(|t| remove_native_type_prefix(NativeType::from(t)));
+ .map(|t| remove_native_type_prefix(&NativeType::from(t)));
let arg_types = arg_types
.into_iter()
- .map(|t| remove_native_type_prefix(NativeType::from(t)))
+ .map(|t| remove_native_type_prefix(&NativeType::from(t)))
.collect::<Vec<_>>();
(arg_types, return_type)
})
@@ -470,7 +470,7 @@ fn get_udwf_args_and_return_types(
// only handle the function which implemented
[`ScalarUDFImpl::return_type`] method
let arg_types = arg_types
.into_iter()
- .map(|t| remove_native_type_prefix(NativeType::from(t)))
+ .map(|t| remove_native_type_prefix(&NativeType::from(t)))
.collect::<Vec<_>>();
(arg_types, None)
})
@@ -479,7 +479,7 @@ fn get_udwf_args_and_return_types(
}
#[inline]
-fn remove_native_type_prefix(native_type: NativeType) -> String {
+fn remove_native_type_prefix(native_type: &NativeType) -> String {
format!("{native_type}")
}
@@ -679,7 +679,7 @@ impl InformationSchemaViewBuilder {
catalog_name: impl AsRef<str>,
schema_name: impl AsRef<str>,
table_name: impl AsRef<str>,
- definition: Option<impl AsRef<str>>,
+ definition: Option<&(impl AsRef<str> + ?Sized)>,
) {
// Note: append_value is actually infallible.
self.catalog_names.append_value(catalog_name.as_ref());
@@ -1164,7 +1164,7 @@ impl InformationSchemaRoutinesBuilder {
routine_name: impl AsRef<str>,
routine_type: impl AsRef<str>,
is_deterministic: bool,
- data_type: Option<impl AsRef<str>>,
+ data_type: Option<&impl AsRef<str>>,
function_type: impl AsRef<str>,
description: Option<impl AsRef<str>>,
syntax_example: Option<impl AsRef<str>>,
@@ -1298,7 +1298,7 @@ impl InformationSchemaParametersBuilder {
specific_name: impl AsRef<str>,
ordinal_position: u64,
parameter_mode: impl AsRef<str>,
- parameter_name: Option<impl AsRef<str>>,
+ parameter_name: Option<&(impl AsRef<str> + ?Sized)>,
data_type: impl AsRef<str>,
parameter_default: Option<impl AsRef<str>>,
is_variadic: bool,
diff --git a/datafusion/catalog/src/lib.rs b/datafusion/catalog/src/lib.rs
index 1c5e384387..da50efbd68 100644
--- a/datafusion/catalog/src/lib.rs
+++ b/datafusion/catalog/src/lib.rs
@@ -23,6 +23,8 @@
// Make sure fast / cheap clones on Arc are explicit:
// https://github.com/apache/datafusion/issues/11143
#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
+#![deny(clippy::needless_pass_by_value)]
+#![cfg_attr(test, allow(clippy::needless_pass_by_value))]
//! Interfaces and default implementations of catalogs and schemas.
//!
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
