This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 47ddd50353 Add link to arrow-rs ticket in comments (#19479)
47ddd50353 is described below
commit 47ddd50353d35f159e6b31123541c0fed0869d58
Author: Andrew Lamb <[email protected]>
AuthorDate: Wed Dec 24 07:35:40 2025 -0500
Add link to arrow-rs ticket in comments (#19479)
## Which issue does this PR close?
- Follow on to https://github.com/apache/datafusion/pull/19441
## Rationale for this change
In https://github.com/apache/datafusion/pull/19441 @Jefffrey filed a
follow on ticket for arrow-rs
https://github.com/apache/arrow-rs/issues/9034
I wanted to leave the context of where it could be used in DataFusion so
we remember to use it when available
## What changes are included in this PR?
Add a comment with a reference to
https://github.com/apache/arrow-rs/issues/9034
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
## Are there any user-facing changes?
No, only comments
---
datafusion/common/src/scalar/mod.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/datafusion/common/src/scalar/mod.rs
b/datafusion/common/src/scalar/mod.rs
index 859b324430..8b68b29d3c 100644
--- a/datafusion/common/src/scalar/mod.rs
+++ b/datafusion/common/src/scalar/mod.rs
@@ -2989,6 +2989,8 @@ impl ScalarValue {
Some(value) => {
let mut builder =
StringViewBuilder::with_capacity(size).with_deduplicate_strings();
+ // Replace with upstream arrow-rs code when available:
+ // https://github.com/apache/arrow-rs/issues/9034
for _ in 0..size {
builder.append_value(value);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
