This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-readonly-queue/main/pr-2191-cb21477fdc4527d6a09accf3da201c086782293e in repository https://gitbox.apache.org/repos/asf/datafusion-sqlparser-rs.git
commit bc55b379c4faf8c3e175a390ff71c16ca891a0e0 Author: Luca Cappelletti <[email protected]> AuthorDate: Fri Feb 6 12:50:30 2026 +0100 Added missing derives to dialect marker structs (#2191) --- src/dialect/ansi.rs | 3 ++- src/dialect/bigquery.rs | 3 ++- src/dialect/clickhouse.rs | 3 ++- src/dialect/databricks.rs | 3 ++- src/dialect/duckdb.rs | 3 ++- src/dialect/generic.rs | 3 ++- src/dialect/hive.rs | 3 ++- src/dialect/mssql.rs | 3 ++- src/dialect/mysql.rs | 3 ++- src/dialect/oracle.rs | 3 ++- src/dialect/postgresql.rs | 3 ++- src/dialect/redshift.rs | 3 ++- src/dialect/snowflake.rs | 3 ++- src/dialect/sqlite.rs | 3 ++- 14 files changed, 28 insertions(+), 14 deletions(-) diff --git a/src/dialect/ansi.rs b/src/dialect/ansi.rs index 5a54390c..89c8a9ea 100644 --- a/src/dialect/ansi.rs +++ b/src/dialect/ansi.rs @@ -18,7 +18,8 @@ use crate::dialect::Dialect; /// A [`Dialect`] for [ANSI SQL](https://en.wikipedia.org/wiki/SQL:2011). -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct AnsiDialect {} impl Dialect for AnsiDialect { diff --git a/src/dialect/bigquery.rs b/src/dialect/bigquery.rs index 5563d133..6cef4606 100644 --- a/src/dialect/bigquery.rs +++ b/src/dialect/bigquery.rs @@ -42,7 +42,8 @@ const RESERVED_FOR_COLUMN_ALIAS: &[Keyword] = &[ ]; /// A [`Dialect`] for [Google Bigquery](https://cloud.google.com/bigquery/) -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct BigQueryDialect; impl Dialect for BigQueryDialect { diff --git a/src/dialect/clickhouse.rs b/src/dialect/clickhouse.rs index f8b6807f..ea4d7a97 100644 --- a/src/dialect/clickhouse.rs +++ b/src/dialect/clickhouse.rs @@ -18,7 +18,8 @@ use crate::dialect::Dialect; /// A [`Dialect`] for [ClickHouse](https://clickhouse.com/). -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct ClickHouseDialect {} impl Dialect for ClickHouseDialect { diff --git a/src/dialect/databricks.rs b/src/dialect/databricks.rs index 40807a01..e903b073 100644 --- a/src/dialect/databricks.rs +++ b/src/dialect/databricks.rs @@ -20,7 +20,8 @@ use crate::dialect::Dialect; /// A [`Dialect`] for [Databricks SQL](https://www.databricks.com/) /// /// See <https://docs.databricks.com/en/sql/language-manual/index.html>. -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct DatabricksDialect; impl Dialect for DatabricksDialect { diff --git a/src/dialect/duckdb.rs b/src/dialect/duckdb.rs index b3803aee..32967c4c 100644 --- a/src/dialect/duckdb.rs +++ b/src/dialect/duckdb.rs @@ -18,7 +18,8 @@ use crate::dialect::Dialect; /// A [`Dialect`] for [DuckDB](https://duckdb.org/) -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct DuckDbDialect; // In most cases the redshift dialect is identical to [`PostgresSqlDialect`]. diff --git a/src/dialect/generic.rs b/src/dialect/generic.rs index 6d25fa2b..38f12cc8 100644 --- a/src/dialect/generic.rs +++ b/src/dialect/generic.rs @@ -19,7 +19,8 @@ use crate::dialect::Dialect; /// A permissive, general purpose [`Dialect`], which parses a wide variety of SQL /// statements, from many different dialects. -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct GenericDialect; impl Dialect for GenericDialect { diff --git a/src/dialect/hive.rs b/src/dialect/hive.rs index 32a982e9..b39232ad 100644 --- a/src/dialect/hive.rs +++ b/src/dialect/hive.rs @@ -18,7 +18,8 @@ use crate::dialect::Dialect; /// A [`Dialect`] for [Hive](https://hive.apache.org/). -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct HiveDialect {} impl Dialect for HiveDialect { diff --git a/src/dialect/mssql.rs b/src/dialect/mssql.rs index 4056bf87..e763165d 100644 --- a/src/dialect/mssql.rs +++ b/src/dialect/mssql.rs @@ -28,7 +28,8 @@ use crate::tokenizer::Token; use alloc::{vec, vec::Vec}; /// A [`Dialect`] for [Microsoft SQL Server](https://www.microsoft.com/en-us/sql-server/) -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct MsSqlDialect {} impl Dialect for MsSqlDialect { diff --git a/src/dialect/mysql.rs b/src/dialect/mysql.rs index 3adb4bc2..e08c1c78 100644 --- a/src/dialect/mysql.rs +++ b/src/dialect/mysql.rs @@ -35,7 +35,8 @@ const RESERVED_FOR_TABLE_ALIAS_MYSQL: &[Keyword] = &[ ]; /// A [`Dialect`] for [MySQL](https://www.mysql.com/) -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct MySqlDialect {} impl Dialect for MySqlDialect { diff --git a/src/dialect/oracle.rs b/src/dialect/oracle.rs index 71b0fdb5..deb7beac 100644 --- a/src/dialect/oracle.rs +++ b/src/dialect/oracle.rs @@ -27,7 +27,8 @@ use super::{keywords::Keyword, Dialect, Precedence}; const RESERVED_KEYWORDS_FOR_SELECT_ITEM_OPERATOR: [Keyword; 1] = [Keyword::CONNECT_BY_ROOT]; /// A [`Dialect`] for [Oracle Databases](https://docs.oracle.com/en/database/oracle/oracle-database/21/sqlrf/index.html) -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct OracleDialect; impl Dialect for OracleDialect { diff --git a/src/dialect/postgresql.rs b/src/dialect/postgresql.rs index 1924a5e3..8e4d78a4 100644 --- a/src/dialect/postgresql.rs +++ b/src/dialect/postgresql.rs @@ -34,7 +34,8 @@ use crate::parser::{Parser, ParserError}; use crate::tokenizer::Token; /// A [`Dialect`] for [PostgreSQL](https://www.postgresql.org/) -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct PostgreSqlDialect {} const PERIOD_PREC: u8 = 200; diff --git a/src/dialect/redshift.rs b/src/dialect/redshift.rs index 7b35848b..21958e38 100644 --- a/src/dialect/redshift.rs +++ b/src/dialect/redshift.rs @@ -22,7 +22,8 @@ use core::str::Chars; use super::PostgreSqlDialect; /// A [`Dialect`] for [RedShift](https://aws.amazon.com/redshift/) -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct RedshiftSqlDialect {} // In most cases the redshift dialect is identical to [`PostgresSqlDialect`]. diff --git a/src/dialect/snowflake.rs b/src/dialect/snowflake.rs index e2d8cb2e..3b6fa1c2 100644 --- a/src/dialect/snowflake.rs +++ b/src/dialect/snowflake.rs @@ -127,7 +127,8 @@ const RESERVED_KEYWORDS_FOR_TABLE_FACTOR: &[Keyword] = &[ ]; /// A [`Dialect`] for [Snowflake](https://www.snowflake.com/) -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct SnowflakeDialect; impl Dialect for SnowflakeDialect { diff --git a/src/dialect/sqlite.rs b/src/dialect/sqlite.rs index 7d1c935f..765b3874 100644 --- a/src/dialect/sqlite.rs +++ b/src/dialect/sqlite.rs @@ -30,7 +30,8 @@ use crate::parser::{Parser, ParserError}; /// [`CREATE TABLE`](https://sqlite.org/lang_createtable.html) statement with no /// type specified, as in `CREATE TABLE t1 (a)`. In the AST, these columns will /// have the data type [`Unspecified`](crate::ast::DataType::Unspecified). -#[derive(Debug, Default)] +#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, Hash, PartialOrd, Ord)] +#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] pub struct SQLiteDialect {} impl Dialect for SQLiteDialect { --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
