This is an automated email from the ASF dual-hosted git repository. blaginin pushed a commit to branch annarose/dict-coercion in repository https://gitbox.apache.org/repos/asf/datafusion-sandbox.git
commit 828e1c1bce79165769375b3bb8595825d48f9623 Author: Nuno Faria <[email protected]> AuthorDate: Wed Feb 4 20:42:25 2026 +0000 fix: Make `serialize_to_file` test cross platform (#20147) ## Which issue does this PR close? - N/A. ## Rationale for this change Make the `serialize_to_file` substrait test work on different platforms. ## What changes are included in this PR? - Updated `serialize_to_file`. ## Are these changes tested? Yes. ## Are there any user-facing changes? No. --- datafusion/substrait/tests/cases/serialize.rs | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/datafusion/substrait/tests/cases/serialize.rs b/datafusion/substrait/tests/cases/serialize.rs index d0f951176..2d7257fad 100644 --- a/datafusion/substrait/tests/cases/serialize.rs +++ b/datafusion/substrait/tests/cases/serialize.rs @@ -17,7 +17,6 @@ #[cfg(test)] mod tests { - use datafusion::common::assert_contains; use datafusion::datasource::provider_as_source; use datafusion::logical_expr::LogicalPlanBuilder; use datafusion_substrait::logical_plan::consumer::from_substrait_plan; @@ -44,8 +43,18 @@ mod tests { serializer::deserialize(path).await?; // Test case 2: serializing to an existing file should fail. - let got = serializer::serialize(sql, &ctx, path).await.unwrap_err(); - assert_contains!(got.to_string(), "File exists"); + let got = serializer::serialize(sql, &ctx, path) + .await + .unwrap_err() + .to_string(); + assert!( + [ + "File exists", // unix + "os error 80" // windows + ] + .iter() + .any(|s| got.contains(s)) + ); fs::remove_file(path)?; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
