This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new df8f818b29 chore: Avoid build fails on MinIO rate limits (#20472)
df8f818b29 is described below
commit df8f818b29d28b0725e169c378afea4f02513e08
Author: Oleks V <[email protected]>
AuthorDate: Mon Feb 23 08:09:01 2026 -0800
chore: Avoid build fails on MinIO rate limits (#20472)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
Sometimes CI failed because of docker rates limits.
```
thread 'test_s3_url_fallback' (11052) panicked at
datafusion-cli/tests/cli_integration.rs:116:13:
Failed to start MinIO container. Ensure Docker is running and accessible:
failed to pull the image 'minio/minio:RELEASE.2025-02-28T09-55-16Z', error:
Docker responded with status code 500: toomanyrequests: You have reached your
unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit
stack backtrace:
```
Example
https://github.com/apache/datafusion/actions/runs/22262073722/job/64401977127
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Ignore the tests if rates limit hit only
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
---
datafusion-cli/tests/cli_integration.rs | 57 +++++++++++++++++++++++----------
1 file changed, 40 insertions(+), 17 deletions(-)
diff --git a/datafusion-cli/tests/cli_integration.rs
b/datafusion-cli/tests/cli_integration.rs
index 8b8b786d65..99fc2d527e 100644
--- a/datafusion-cli/tests/cli_integration.rs
+++ b/datafusion-cli/tests/cli_integration.rs
@@ -44,7 +44,7 @@ fn make_settings() -> Settings {
settings
}
-async fn setup_minio_container() -> ContainerAsync<minio::MinIO> {
+async fn setup_minio_container() -> Result<ContainerAsync<minio::MinIO>,
String> {
const MINIO_ROOT_USER: &str = "TEST-DataFusionLogin";
const MINIO_ROOT_PASSWORD: &str = "TEST-DataFusionPassword";
@@ -99,27 +99,23 @@ async fn setup_minio_container() ->
ContainerAsync<minio::MinIO> {
let stdout =
container.stdout_to_vec().await.unwrap_or_default();
let stderr =
container.stderr_to_vec().await.unwrap_or_default();
- panic!(
+ return Err(format!(
"Failed to execute command: {}\nError: {}\nStdout:
{:?}\nStderr: {:?}",
cmd_ref,
e,
String::from_utf8_lossy(&stdout),
String::from_utf8_lossy(&stderr)
- );
+ ));
}
}
- container
+ Ok(container)
}
- Err(TestcontainersError::Client(e)) => {
- panic!(
- "Failed to start MinIO container. Ensure Docker is running and
accessible: {e}"
- );
- }
- Err(e) => {
- panic!("Failed to start MinIO container: {e}");
- }
+ Err(TestcontainersError::Client(e)) => Err(format!(
+ "Failed to start MinIO container. Ensure Docker is running and
accessible: {e}"
+ )),
+ Err(e) => Err(format!("Failed to start MinIO container: {e}")),
}
}
@@ -253,7 +249,14 @@ async fn test_cli() {
return;
}
- let container = setup_minio_container().await;
+ let container = match setup_minio_container().await {
+ Ok(c) => c,
+ Err(e) if e.contains("toomanyrequests") => {
+ eprintln!("Skipping test: Docker pull rate limit reached: {e}");
+ return;
+ }
+ e @ Err(_) => e.unwrap(),
+ };
let settings = make_settings();
let _bound = settings.bind_to_scope();
@@ -286,7 +289,14 @@ async fn test_aws_options() {
let settings = make_settings();
let _bound = settings.bind_to_scope();
- let container = setup_minio_container().await;
+ let container = match setup_minio_container().await {
+ Ok(c) => c,
+ Err(e) if e.contains("toomanyrequests") => {
+ eprintln!("Skipping test: Docker pull rate limit reached: {e}");
+ return;
+ }
+ e @ Err(_) => e.unwrap(),
+ };
let port = container.get_host_port_ipv4(9000).await.unwrap();
let input = format!(
@@ -377,7 +387,14 @@ async fn test_s3_url_fallback() {
return;
}
- let container = setup_minio_container().await;
+ let container = match setup_minio_container().await {
+ Ok(c) => c,
+ Err(e) if e.contains("toomanyrequests") => {
+ eprintln!("Skipping test: Docker pull rate limit reached: {e}");
+ return;
+ }
+ e @ Err(_) => e.unwrap(),
+ };
let mut settings = make_settings();
settings.set_snapshot_suffix("s3_url_fallback");
@@ -407,8 +424,14 @@ async fn test_object_store_profiling() {
return;
}
- let container = setup_minio_container().await;
-
+ let container = match setup_minio_container().await {
+ Ok(c) => c,
+ Err(e) if e.contains("toomanyrequests") => {
+ eprintln!("Skipping test: Docker pull rate limit reached: {e}");
+ return;
+ }
+ e @ Err(_) => e.unwrap(),
+ };
let mut settings = make_settings();
// as the object store profiling contains timestamps and durations, we must
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
