This is an automated email from the ASF dual-hosted git repository.
milenkovicm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-ballista.git
The following commit(s) were added to refs/heads/main by this push:
new dc47c71f7 minor: task scheduling policy config cleanup (#1507)
dc47c71f7 is described below
commit dc47c71f77de0895c75d140af2299e9ca9811362
Author: Marko Milenković <[email protected]>
AuthorDate: Sun Mar 15 11:15:21 2026 +0000
minor: task scheduling policy config cleanup (#1507)
---
ballista/core/src/config.rs | 3 +++
ballista/executor/src/config.rs | 2 +-
ballista/scheduler/src/config.rs | 4 ++--
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/ballista/core/src/config.rs b/ballista/core/src/config.rs
index 2fde0a2b2..41daae4f6 100644
--- a/ballista/core/src/config.rs
+++ b/ballista/core/src/config.rs
@@ -482,6 +482,9 @@ pub enum TaskSchedulingPolicy {
/// Pull-based scheduling works in a similar way to Apache Spark
PullStaged,
/// push-based scheduling can result in lower latency.
+ // scheduler & executor cli configuration to be updated
+ // if we change default value, as they state which policy
+ // is default.
#[default]
PushStaged,
}
diff --git a/ballista/executor/src/config.rs b/ballista/executor/src/config.rs
index 56b8002da..c3700142e 100644
--- a/ballista/executor/src/config.rs
+++ b/ballista/executor/src/config.rs
@@ -78,7 +78,7 @@ pub struct Config {
)]
pub concurrent_tasks: usize,
/// Task scheduling policy: pull-staged (executor polls) or push-staged
(scheduler pushes).
- #[arg(short = 's', long, default_value_t =
ballista_core::config::TaskSchedulingPolicy::PushStaged, help = "The task
scheduling policy for the scheduler, possible values: pull-staged, push-staged.
Default: push-staged")]
+ #[arg(short = 's', long, default_value_t =
ballista_core::config::TaskSchedulingPolicy::default(), help = "The task
scheduling policy for the scheduler, possible values: pull-staged, push-staged.
Default: push-staged")]
pub task_scheduling_policy: ballista_core::config::TaskSchedulingPolicy,
/// Interval in seconds between job data cleanup runs (0 = disabled).
#[arg(
diff --git a/ballista/scheduler/src/config.rs b/ballista/scheduler/src/config.rs
index 4f520aff5..41c218ec7 100644
--- a/ballista/scheduler/src/config.rs
+++ b/ballista/scheduler/src/config.rs
@@ -68,8 +68,8 @@ pub struct Config {
#[arg(
short = 's',
long,
- default_value_t =
ballista_core::config::TaskSchedulingPolicy::PushStaged,
- help = "The scheduling policy for the scheduler, possible values:
pull-staged, push-staged. Default: pull-staged"
+ default_value_t =
ballista_core::config::TaskSchedulingPolicy::default(),
+ help = "The scheduling policy for the scheduler, possible values:
pull-staged, push-staged. Default: push-staged"
)]
pub scheduler_policy: ballista_core::config::TaskSchedulingPolicy,
/// Event loop buffer size for high throughput systems.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
