This is an automated email from the ASF dual-hosted git repository.
agrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new 3c154ca8f fix: correct invalid Option.contains assertion in cast test
(#3851)
3c154ca8f is described below
commit 3c154ca8f051a41e3537bca836b7e1b1327ee335
Author: Manu Zhang <[email protected]>
AuthorDate: Tue Mar 31 22:53:59 2026 +0800
fix: correct invalid Option.contains assertion in cast test (#3851)
---
spark/src/test/scala/org/apache/comet/CometCastSuite.scala | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/spark/src/test/scala/org/apache/comet/CometCastSuite.scala
b/spark/src/test/scala/org/apache/comet/CometCastSuite.scala
index 9a0d42102..f3eb9033b 100644
--- a/spark/src/test/scala/org/apache/comet/CometCastSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/CometCastSuite.scala
@@ -27,6 +27,7 @@ import scala.util.Random
import org.apache.hadoop.fs.Path
import org.apache.spark.sql.{CometTestBase, DataFrame, Row, SaveMode}
import org.apache.spark.sql.catalyst.expressions.Cast
+import org.apache.spark.sql.catalyst.parser.ParseException
import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper
import org.apache.spark.sql.functions.col
import org.apache.spark.sql.internal.SQLConf
@@ -1287,8 +1288,13 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
// cast to negative scale
checkSparkAnswerMaybeThrows(
spark.sql("select a, cast(a as DECIMAL(10,-4)) from t order by a"))
match {
+ case (Some(expected: ParseException), Some(actual: ParseException)) =>
+ assert(
+ expected.getMessage.contains("PARSE_SYNTAX_ERROR") &&
actual.getMessage.contains(
+ "PARSE_SYNTAX_ERROR"))
case (expected, actual) =>
- assert(expected.contains("PARSE_SYNTAX_ERROR") ===
actual.contains("PARSE_SYNTAX_ERROR"))
+ fail(
+ s"Expected Spark and Comet throw ParseException, but got
Spark=$expected and Comet=$actual")
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
