This is an automated email from the ASF dual-hosted git repository.
mbutrovich pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new a2fd51bae fix: cargo clean before release build to avoid stale native
libs (#4257)
a2fd51bae is described below
commit a2fd51baed1eecd6707512020b6fbbfea38d8019
Author: Andy Grove <[email protected]>
AuthorDate: Thu May 7 11:16:25 2026 -0600
fix: cargo clean before release build to avoid stale native libs (#4257)
---
dev/release/build-release-comet.sh | 7 +++++++
docs/source/contributor-guide/release_process.md | 15 +++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/dev/release/build-release-comet.sh
b/dev/release/build-release-comet.sh
index 91d02885a..d0171eb98 100755
--- a/dev/release/build-release-comet.sh
+++ b/dev/release/build-release-comet.sh
@@ -125,6 +125,13 @@ docker build --no-cache \
# Clean previous Java build
pushd $COMET_HOME_DIR && ./mvnw clean && popd
+# Clean previous native build. This is required because common/pom.xml has
+# unconditional resource entries that bundle libcomet.dylib from
+# native/target/{x86_64,aarch64}-apple-darwin/release. If a release manager
+# previously cross-compiled those targets locally, stale dylibs would leak
+# into the release jars. See
https://github.com/apache/datafusion-comet/issues/2232
+pushd $COMET_HOME_DIR/native && cargo clean && popd
+
# Run the builder container for each architecture. The entrypoint script will
build the binaries
# AMD64
diff --git a/docs/source/contributor-guide/release_process.md
b/docs/source/contributor-guide/release_process.md
index 2a3c07adb..23d2b9110 100644
--- a/docs/source/contributor-guide/release_process.md
+++ b/docs/source/contributor-guide/release_process.md
@@ -158,6 +158,21 @@ commit into the release branch.
### Build the jars
+#### A note on workspace cleanliness
+
+The `common/pom.xml` resource configuration unconditionally bundles
+`native/target/{x86_64,aarch64}-apple-darwin/release/libcomet.dylib` into the
+`common` jar when those files exist on disk. Maven's `clean` removes
+`common/target` but does not touch Cargo's `native/target` directory, so a
+stale dylib left over from a prior local `make release` or `make release-linux`
+on the release manager's workstation can silently end up in a release jar
+(see [#2232](https://github.com/apache/datafusion-comet/issues/2232) for the
+incident in 0.9.1).
+
+The `build-release-comet.sh` script now runs `cargo clean` for you, but as a
+defensive measure, prefer running the release build from a fresh clone of the
+repository rather than your day-to-day working tree.
+
#### Setup to do the build
The build process requires Docker. Download the latest Docker Desktop from
https://www.docker.com/products/docker-desktop/.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
