This is an automated email from the ASF dual-hosted git repository.
rluvaton pushed a commit to branch breaking-change-detector-api-test
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to
refs/heads/breaking-change-detector-api-test by this push:
new 20a4cdb936 remove breaking change detector comment and replace with
log to see if it is working
20a4cdb936 is described below
commit 20a4cdb93619329004deb9eeddd09270b3c37fc5
Author: Raz Luvaton <[email protected]>
AuthorDate: Wed May 27 18:06:12 2026 +0300
remove breaking change detector comment and replace with log to see if it
is working
---
.../breaking_changes_detector_comment.yml | 97 ++--------------------
1 file changed, 5 insertions(+), 92 deletions(-)
diff --git a/.github/workflows/breaking_changes_detector_comment.yml
b/.github/workflows/breaking_changes_detector_comment.yml
index 579c61cb9d..55f71cb105 100644
--- a/.github/workflows/breaking_changes_detector_comment.yml
+++ b/.github/workflows/breaking_changes_detector_comment.yml
@@ -65,96 +65,9 @@ jobs:
# Scoped to the minimum needed to upsert/delete the sticky comment.
permissions:
actions: read
- pull-requests: write
- steps:
- - name: Download semver-check artifact
- uses:
actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
- with:
- name: semver-check-result
- run-id: ${{ github.event.workflow_run.id }}
- github-token: ${{ github.token }}
- path: ./semver-artifact
-
- - name: Read and validate artifact
- id: read
- run: |
- set -euo pipefail
- # Validate every field: the artifact comes from a workflow run
- # that compiled fork-controlled code, so its contents are untrusted.
- PR_NUMBER=$(cat ./semver-artifact/pr_number)
- if ! [[ "$PR_NUMBER" =~ ^[0-9]+$ ]]; then
- echo "Invalid PR number: $PR_NUMBER" >&2
- exit 1
- fi
- CHECK_RESULT=$(cat ./semver-artifact/result)
- if [[ "$CHECK_RESULT" != "success" && "$CHECK_RESULT" != "failure"
]]; then
- echo "Invalid check result: $CHECK_RESULT" >&2
- exit 1
- fi
- echo "pr_number=$PR_NUMBER" >> "$GITHUB_OUTPUT"
- echo "result=$CHECK_RESULT" >> "$GITHUB_OUTPUT"
-
- # Multi-line output: random delimiter so a malicious log line can't
- # close the heredoc and inject extra output keys. See:
- #
https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#multiline-strings
- DELIM="EOF_$(openssl rand -hex 16)"
- {
- echo "logs<<${DELIM}"
- cat ./semver-artifact/logs
- echo "${DELIM}"
- } >> "$GITHUB_OUTPUT"
-
- # The marker `<!-- semver-check-comment -->` is what makes the comment
- # "sticky": maintain-one-comment uses it to find and replace (or
- # delete) the existing comment instead of stacking new ones.
- - name: Upsert sticky comment
- if: steps.read.outputs.result != 'success'
- uses:
actions-cool/maintain-one-comment@909842216bc8e8658364c572ec52100f4c2cc50a #
v3.3.0
- with:
- token: ${{ secrets.GITHUB_TOKEN }}
- number: ${{ steps.read.outputs.pr_number }}
- body-include: '<!-- semver-check-comment -->'
- body: |
- <!-- semver-check-comment -->
- Thank you for opening this pull request!
-
- Reviewer note:
[cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks)
reported the current version number is not SemVer-compatible with the changes
in this pull request (compared against the base branch).
-
- <details>
- <summary>Details</summary>
+ pull-requests: read
- ```
- ${{ steps.read.outputs.logs }}
- ```
-
- </details>
-
- - name: Delete sticky comment
- if: steps.read.outputs.result == 'success'
- uses:
actions-cool/maintain-one-comment@909842216bc8e8658364c572ec52100f4c2cc50a #
v3.3.0
- with:
- token: ${{ secrets.GITHUB_TOKEN }}
- number: ${{ steps.read.outputs.pr_number }}
- body-include: '<!-- semver-check-comment -->'
- delete: true
-
- - name: Add "auto detected api change" label
- if: steps.read.outputs.result != 'success'
- env:
- GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- REPO: ${{ github.repository }}
- PR_NUMBER: ${{ steps.read.outputs.pr_number }}
- run: |
- gh pr edit "$PR_NUMBER" --repo "$REPO" \
- --add-label "$BREAKING_CHANGE_LABEL"
-
- - name: Remove "auto detected api change" label
- if: steps.read.outputs.result == 'success'
- env:
- GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- REPO: ${{ github.repository }}
- PR_NUMBER: ${{ steps.read.outputs.pr_number }}
- run: |
- # No-op when the label isn't currently applied.
- gh pr edit "$PR_NUMBER" --repo "$REPO" \
- --remove-label "$BREAKING_CHANGE_LABEL" || true
+ # Check if working at all
+ steps:
+ - name: echo
+ run: echo "HELLLO"
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
