This is an automated email from the ASF dual-hosted git repository.
andygrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new f58e624322 docs: fix sidebar drawer mis-tap, missing aria-expanded,
homepage permalink, and ASF links page (#4858)
f58e624322 is described below
commit f58e624322c1ad459296c8ec91a823a00ed74a33
Author: Pranamya Vadlamani <[email protected]>
AuthorDate: Wed Jul 8 08:21:59 2026 -0500
docs: fix sidebar drawer mis-tap, missing aria-expanded, homepage
permalink, and ASF links page (#4858)
- Mobile sidebar drawer: tapping the hamburger's screen position while
the drawer was open hit an injected "Home" link underneath it instead
of closing the menu. Push the drawer's own nav content down so it
doesn't overlap that corner.
- Sidebar section-title toggle wasn't exposing its open/closed state to
screen readers. Sync aria-expanded with the details element.
- The homepage hero title showed a heading permalink ("#") that doesn't
make sense on a marketing landing page. Hide it there, keep it working
on regular docs pages.
- The ASF Links page said "select a link from the navigation menu" but
the links only existed in a hidden sidebar toctree, never in the page
itself. Show them as a plain list in the page body instead.
---
docs/source/_static/comet-ux.js | 8 ++++++++
docs/source/_static/theme_overrides.css | 21 +++++++++++++++++----
docs/source/asf/index.md | 19 ++++++-------------
3 files changed, 31 insertions(+), 17 deletions(-)
diff --git a/docs/source/_static/comet-ux.js b/docs/source/_static/comet-ux.js
index af3f6b9ff8..39a05c4e4b 100644
--- a/docs/source/_static/comet-ux.js
+++ b/docs/source/_static/comet-ux.js
@@ -221,6 +221,14 @@
titles.forEach(function (link) {
var details = link.nextElementSibling;
if (!details || details.tagName !== 'DETAILS') return;
+ link.setAttribute('role', 'button');
+ link.setAttribute('aria-expanded', details.open ? 'true' : 'false');
+ // Listen on <details>'s own toggle event, not just this link's click,
+ // so aria-expanded stays correct whether the chevron/summary or the
+ // title triggered the change.
+ details.addEventListener('toggle', function () {
+ link.setAttribute('aria-expanded', details.open ? 'true' : 'false');
+ });
link.addEventListener('click', function (e) {
e.preventDefault();
details.open = !details.open;
diff --git a/docs/source/_static/theme_overrides.css
b/docs/source/_static/theme_overrides.css
index 558cf4ed23..4a0b5a3baf 100644
--- a/docs/source/_static/theme_overrides.css
+++ b/docs/source/_static/theme_overrides.css
@@ -684,10 +684,19 @@ html[data-theme="light"] .bd-links
li.current:not(:has(li.current)) > a.current.
font-weight: 400 !important;
}
-/* Mobile sidebar nav header */
+/* Mobile sidebar nav header. Extra top padding: the mobile off-canvas
+ sidebar is a native <dialog> opened via showModal(), which the browser
+ promotes to the "top layer" above everything else and makes the rest of
+ the page inert — so the hamburger button behind it is never reachable
+ while the drawer is open, by design (Escape and tapping the backdrop
+ both already close it correctly). But this drawer's own first item —
+ the "Home" link comet-ux.js prepends into its nav copy — sat close
+ enough to the header's hamburger position that a user instinctively
+ tapping there to close the menu was likely to hit "Home" and navigate
+ away instead. Push it down so it doesn't overlap that corner. */
.sidebar-header-items {
border-bottom: 1px solid var(--pst-color-border) !important;
- padding: 8px 0 !important;
+ padding: 56px 0 8px !important;
}
/* ─── LAYOUT GRID ──────────────────────────────────────────────────── */
@@ -1344,10 +1353,14 @@ body:has(.comet-hero) article.bd-article {
/* Landing page: hide chrome that doesn't belong on a marketing page.
The H1 stays (now lives inside the hero as the project's brand statement)
- so we no longer hide it. */
+ so we no longer hide it. myst_heading_anchors auto-adds a "#" permalink
+ next to every heading so readers can deep-link to a doc subsection —
+ useful on regular content pages, but meaningless on the hero title of a
+ landing page, so it's hidden here specifically. */
body:has(.comet-hero) .bd-breadcrumbs,
body:has(.comet-hero) footer.prev-next-footer,
-body:has(.comet-hero) .prev-next-area {
+body:has(.comet-hero) .prev-next-area,
+body:has(.comet-hero) a.headerlink {
display: none !important;
}
diff --git a/docs/source/asf/index.md b/docs/source/asf/index.md
index e461f68d47..2aec9e7364 100644
--- a/docs/source/asf/index.md
+++ b/docs/source/asf/index.md
@@ -21,17 +21,10 @@ under the License.
Apache DataFusion Comet is part of the Apache Software Foundation. The links
below point to ASF
resources covering licensing, donations, security reporting, and the
Foundation's code of conduct.
-Select a link from the navigation menu.
-```{toctree}
-:maxdepth: 1
-:caption: ASF Links
-:hidden:
-
-Apache Software Foundation <https://apache.org>
-License <https://www.apache.org/licenses/>
-Donate <https://www.apache.org/foundation/sponsorship.html>
-Thanks <https://www.apache.org/foundation/thanks.html>
-Security <https://www.apache.org/security/>
-Code of conduct <https://www.apache.org/foundation/policies/conduct.html>
-```
+- [Apache Software Foundation](https://apache.org)
+- [License](https://www.apache.org/licenses/)
+- [Donate](https://www.apache.org/foundation/sponsorship.html)
+- [Thanks](https://www.apache.org/foundation/thanks.html)
+- [Security](https://www.apache.org/security/)
+- [Code of conduct](https://www.apache.org/foundation/policies/conduct.html)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
