This is an automated email from the ASF dual-hosted git repository.

Rachelint pushed a commit to branch improve-compare-in-view-map-v2
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/improve-compare-in-view-map-v2 
by this push:
     new a78ea2bb93 quick test.
a78ea2bb93 is described below

commit a78ea2bb939ab959a8db0e0a85e700d18500939d
Author: kamille <[email protected]>
AuthorDate: Thu Jul 9 14:06:28 2026 +0800

    quick test.
---
 .../physical-expr-common/src/binary_view_map.rs    | 28 +++++++++++-----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/datafusion/physical-expr-common/src/binary_view_map.rs 
b/datafusion/physical-expr-common/src/binary_view_map.rs
index 53b84e7dea..110fd5f761 100644
--- a/datafusion/physical-expr-common/src/binary_view_map.rs
+++ b/datafusion/physical-expr-common/src/binary_view_map.rs
@@ -296,20 +296,20 @@ where
             let hash = self.hashes_buffer[i];
 
             // handle null value via validity bitmap check
-            if values.is_null(i) {
-                let payload = if let Some(&(payload, _offset)) = 
self.null.as_ref() {
-                    payload
-                } else {
-                    let payload = make_payload_fn(None);
-                    let null_index = self.views.len();
-                    self.views.push(0);
-                    self.nulls.append_null();
-                    self.null = Some((payload, null_index));
-                    payload
-                };
-                observe_payload_fn(payload);
-                continue;
-            }
+            // if values.is_null(i) {
+            //     let payload = if let Some(&(payload, _offset)) = 
self.null.as_ref() {
+            //         payload
+            //     } else {
+            //         let payload = make_payload_fn(None);
+            //         let null_index = self.views.len();
+            //         self.views.push(0);
+            //         self.nulls.append_null();
+            //         self.null = Some((payload, null_index));
+            //         payload
+            //     };
+            //     observe_payload_fn(payload);
+            //     continue;
+            // }
 
             // Extract length from the view (first 4 bytes of u128 in 
little-endian)
             let len = view_u128 as u32;


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to