This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-sqlparser-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 86a61436 Fix clippy lints for Rust 1.97 (#2402)
86a61436 is described below
commit 86a61436587f2ffdfd916f4966a5dba463266d5f
Author: Takahiro Ebato <[email protected]>
AuthorDate: Sun Jul 12 17:19:16 2026 +0900
Fix clippy lints for Rust 1.97 (#2402)
---
examples/cli.rs | 4 ++--
src/ast/ddl.rs | 2 +-
src/ast/mod.rs | 2 +-
src/ast/query.rs | 2 +-
src/parser/mod.rs | 8 ++++----
tests/sqlparser_common.rs | 6 +++---
tests/sqlparser_postgres.rs | 4 ++--
7 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/examples/cli.rs b/examples/cli.rs
index 3c4299b2..51a63a7e 100644
--- a/examples/cli.rs
+++ b/examples/cli.rs
@@ -71,9 +71,9 @@ $ cargo run --example cli - [--dialectname]
.expect("failed to read from stdin");
String::from_utf8(buf).expect("stdin content wasn't valid utf8")
} else {
- println!("Parsing from file '{}' using {:?}", &filename, dialect);
+ println!("Parsing from file '{}' using {:?}", filename, dialect);
fs::read_to_string(&filename)
- .unwrap_or_else(|_| panic!("Unable to read the file {}",
&filename))
+ .unwrap_or_else(|_| panic!("Unable to read the file {}", filename))
};
let without_bom = if contents.chars().next().unwrap() as u64 != 0xfeff {
contents.as_str()
diff --git a/src/ast/ddl.rs b/src/ast/ddl.rs
index 346627c6..ece60237 100644
--- a/src/ast/ddl.rs
+++ b/src/ast/ddl.rs
@@ -4780,7 +4780,7 @@ impl fmt::Display for AlterTable {
if self.only {
write!(f, "ONLY ")?;
}
- write!(f, "{} ", &self.name)?;
+ write!(f, "{} ", self.name)?;
if let Some(cluster) = &self.on_cluster {
write!(f, "ON CLUSTER {cluster} ")?;
}
diff --git a/src/ast/mod.rs b/src/ast/mod.rs
index 88883cfb..5bc7070e 100644
--- a/src/ast/mod.rs
+++ b/src/ast/mod.rs
@@ -11842,7 +11842,7 @@ impl fmt::Display for AlterUser {
let has_props = !self.set_props.options.is_empty();
if has_props {
write!(f, " SET")?;
- write!(f, " {}", &self.set_props)?;
+ write!(f, " {}", self.set_props)?;
}
if !self.unset_props.is_empty() {
write!(f, " UNSET {}",
display_comma_separated(&self.unset_props))?;
diff --git a/src/ast/query.rs b/src/ast/query.rs
index eb209228..fdcacddf 100644
--- a/src/ast/query.rs
+++ b/src/ast/query.rs
@@ -3545,7 +3545,7 @@ pub struct LockClause {
impl fmt::Display for LockClause {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
- write!(f, "FOR {}", &self.lock_type)?;
+ write!(f, "FOR {}", self.lock_type)?;
if let Some(ref of) = self.of {
write!(f, " OF {of}")?;
}
diff --git a/src/parser/mod.rs b/src/parser/mod.rs
index 8b998b02..09715bbc 100644
--- a/src/parser/mod.rs
+++ b/src/parser/mod.rs
@@ -4845,7 +4845,7 @@ impl<'a> Parser<'a> {
if self.parse_keyword(expected) {
Ok(self.get_current_token().clone())
} else {
- self.expected_ref(format!("{:?}", &expected).as_str(),
self.peek_token_ref())
+ self.expected_ref(format!("{:?}", expected).as_str(),
self.peek_token_ref())
}
}
@@ -4858,7 +4858,7 @@ impl<'a> Parser<'a> {
if self.parse_keyword(expected) {
Ok(())
} else {
- self.expected_ref(format!("{:?}", &expected).as_str(),
self.peek_token_ref())
+ self.expected_ref(format!("{:?}", expected).as_str(),
self.peek_token_ref())
}
}
@@ -13724,7 +13724,7 @@ impl<'a> Parser<'a> {
}
Token::EOF => break,
token => {
- return Err(ParserError::ParserError(format!(
+ Err(ParserError::ParserError(format!(
"Unexpected token in identifier: {token}"
)))?;
}
@@ -17012,7 +17012,7 @@ impl<'a> Parser<'a> {
where_clause = Some(self.parse_expr()?);
} else {
let tok = self.peek_token_ref();
- return parser_err!(
+ parser_err!(
format!(
"Expected one of DIMENSIONS, METRICS, FACTS or WHERE,
got {}",
tok.token
diff --git a/tests/sqlparser_common.rs b/tests/sqlparser_common.rs
index 634b9aea..50832d06 100644
--- a/tests/sqlparser_common.rs
+++ b/tests/sqlparser_common.rs
@@ -1731,7 +1731,7 @@ fn parse_json_ops_without_colon() {
];
for (str_op, op, dialects) in binary_ops {
- let select = dialects.verified_only_select(&format!("SELECT a {} b",
&str_op));
+ let select = dialects.verified_only_select(&format!("SELECT a {} b",
str_op));
assert_eq!(
SelectItem::UnnamedExpr(Expr::BinaryOp {
left: Box::new(Expr::Identifier(Ident::new("a"))),
@@ -2441,7 +2441,7 @@ fn parse_bitwise_ops() {
];
for (str_op, op, dialects) in bitwise_ops {
- let select = dialects.verified_only_select(&format!("SELECT a {} b",
&str_op));
+ let select = dialects.verified_only_select(&format!("SELECT a {} b",
str_op));
assert_eq!(
SelectItem::UnnamedExpr(Expr::BinaryOp {
left: Box::new(Expr::Identifier(Ident::new("a"))),
@@ -19100,7 +19100,7 @@ fn parse_generic_unary_ops() {
("+", UnaryOperator::Plus),
];
for (str_op, op) in unary_ops {
- let select = verified_only_select(&format!("SELECT {}expr", &str_op));
+ let select = verified_only_select(&format!("SELECT {}expr", str_op));
assert_eq!(
UnnamedExpr(UnaryOp {
op: *op,
diff --git a/tests/sqlparser_postgres.rs b/tests/sqlparser_postgres.rs
index 47e60e07..9ee6ab3d 100644
--- a/tests/sqlparser_postgres.rs
+++ b/tests/sqlparser_postgres.rs
@@ -2574,7 +2574,7 @@ fn parse_pg_unary_ops() {
("@", UnaryOperator::PGAbs),
];
for (str_op, op) in pg_unary_ops {
- let select = pg().verified_only_select(&format!("SELECT {}a",
&str_op));
+ let select = pg().verified_only_select(&format!("SELECT {}a", str_op));
assert_eq!(
SelectItem::UnnamedExpr(Expr::UnaryOp {
op: *op,
@@ -2590,7 +2590,7 @@ fn parse_pg_postfix_factorial() {
let postfix_factorial = &[("!", UnaryOperator::PGPostfixFactorial)];
for (str_op, op) in postfix_factorial {
- let select = pg().verified_only_select(&format!("SELECT a{}",
&str_op));
+ let select = pg().verified_only_select(&format!("SELECT a{}", str_op));
assert_eq!(
SelectItem::UnnamedExpr(Expr::UnaryOp {
op: *op,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
