This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new ccdff0a4bf chore: remove JaCoCo from the build (#6084)
ccdff0a4bf is described below
commit ccdff0a4bfeee377ffa8654a1ef7843e63b3b8b8
Author: Andy Grove <[email protected]>
AuthorDate: Mon Sep 21 20:01:26 2026 +0000
chore: remove JaCoCo from the build (#6084)
JaCoCo was added in #163 to publish JVM coverage to Codecov. #3381 removed
the codecov upload step, which was the only consumer, but left the plugin
in place. Since then every build has instrumented every forked test JVM and
generated a report that nothing reads: no CI step uploads it, no check rule
gates on it, and no path in the repo references it.
It was never configured to measure much either. There is no
report-aggregate,
so each module reports against its own exec file; common has no test sources
of its own, so its report is always skipped even though its classes are
exercised by the spark module's tests.
Also drop "including coverage" from the upload-test-reports description in
the java-test action, which has been stale since #3381 -- the step it guards
uploads surefire .txt reports only.
---
.github/actions/java-test/action.yaml | 2 +-
pom.xml | 25 -------------------------
2 files changed, 1 insertion(+), 26 deletions(-)
diff --git a/.github/actions/java-test/action.yaml
b/.github/actions/java-test/action.yaml
index 36dd15f580..78eebf40e8 100644
--- a/.github/actions/java-test/action.yaml
+++ b/.github/actions/java-test/action.yaml
@@ -30,7 +30,7 @@ inputs:
required: false
default: ''
upload-test-reports:
- description: 'Whether to upload test results including coverage to GitHub'
+ description: 'Whether to upload test results to GitHub'
required: false
default: 'false'
skip-native-build:
diff --git a/pom.xml b/pom.xml
index 3288c69fa7..23a3c08bb2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -89,7 +89,6 @@ under the License.
<arrow.version>18.3.0</arrow.version>
<codehaus.jackson.version>1.9.13</codehaus.jackson.version>
<spotless.version>2.43.0</spotless.version>
- <jacoco.version>0.8.11</jacoco.version>
<semanticdb.version>4.13.6</semanticdb.version>
<slf4j.version>2.0.17</slf4j.version>
<guava.version>33.2.1-jre</guava.version>
@@ -1041,11 +1040,6 @@ under the License.
<artifactId>flatten-maven-plugin</artifactId>
<version>${flatten-maven-plugin.version}</version>
</plugin>
- <plugin>
- <groupId>org.jacoco</groupId>
- <artifactId>jacoco-maven-plugin</artifactId>
- <version>${jacoco.version}</version>
- </plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
@@ -1304,25 +1298,6 @@ under the License.
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.jacoco</groupId>
- <artifactId>jacoco-maven-plugin</artifactId>
- <executions>
- <execution>
- <id>default-prepare-agent</id>
- <goals>
- <goal>prepare-agent</goal>
- </goals>
- </execution>
- <execution>
- <id>report</id>
- <phase>test</phase>
- <goals>
- <goal>report</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
</plugins>
</build>
</project>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
